Maven Surefire

Support tests written in Jython

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Maven Surefire Plugin
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    4

Description

I've written a first pass at a surefire-provider for JUnit and Python unittest TestCases written in Jython. Before I continue any further I'd like to make sure that the provider is wanted and that I'm heading in the right direction.

To do the minimum to get it up and running, I've hooked into the maven-surefire-plugin to hook my provider into the system somewhat like the TestNG provider did. maven-surefire-plugin passes a path(defaults to src/test/jython) to the provider. The provider searches the path for files matching include patterns and loads those as Python modules. For every class in the matching modules that extends junit or unittest TestCase, it makes a SurefireTestSuite and exposes them for running. Sound like a decent approach?

To give it a spin, apply maven-surefire-plugin.patch, mvn install on the surefire-jython project and run mvn test in jythonProviderTest. It's just contains a single Junit testcase with a failing and passing test.

I haven't even checked what happens when the jython tests throw exceptions, and I know there's alot to be done as far as making it a usable plugin, but I felt like getting some feedback before continuing.

  1. GZip Archive
    jythonProvider.tar.gz
    29/May/06 2:07 AM
    7 kB
    Charlie Groves
  2. GZip Archive
    jythonProviderTest.tar.gz
    18/Sep/06 1:41 AM
    0.7 kB
    Charlie Groves
  3. Text File
    MSUREFIRE-122-maven-surefire-plugin.patch
    18/Sep/06 1:41 AM
    5 kB
    Charlie Groves
  4. Text File
    MSUREFIRE-122-surefire-providers.patch
    18/Sep/06 1:41 AM
    26 kB
    Charlie Groves

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

Not sure if anybody is interested but if it works can be added. Getting votes in this issue will help though.

Show
Carlos Sanchez added a comment - Not sure if anybody is interested but if it works can be added. Getting votes in this issue will help though.
Hide
Permalink
Charlie Groves added a comment -

Have we hit enough votes to start integrating this?

Show
Charlie Groves added a comment - Have we hit enough votes to start integrating this?
Hide
Permalink
fabrizio giustina added a comment -

Hi Charlie,
I tried to integrate your patches, but looks like that tests on the jythonProviderTest don't work properly. After adding the surefire-jython provider and applying your patch to the maven surefire plugin this is what I get when I try running tests:

[INFO] Surefire report directory: \jythonProvider.tar\jythonProvider\jythonProviderTest\target\surefire-reports
sys-package-mgr: processing new jar, 'C:\repository\m2\jython\jython\2.2-alpha1\jython-2.2-alpha1.jar'
org.apache.maven.surefire.booter.SurefireExecutionException: Problem reflecting on class org.python.core.PySystemState; nested exception is java.lang.reflect.InvocationTargetException: null; nested exception is
org.apache.maven.surefire.testset.TestSetFailedException: Problem reflecting on class org.python.core.PySystemState; nested exception is java.lang.reflect.InvocationTargetException: null
org.apache.maven.surefire.testset.TestSetFailedException: Problem reflecting on class org.python.core.PySystemState; nested exception is java.lang.reflect.InvocationTargetException: null
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.maven.surefire.jython.JythonDirectoryTestSuite.setupInterpreter(JythonDirectoryTestSuite.java:130)
at org.apache.maven.surefire.jython.JythonDirectoryTestSuite.locateTestSets(JythonDirectoryTestSuite.java:102)
at org.apache.maven.surefire.Surefire.createSuiteFromDefinition(Surefire.java:147)
at org.apache.maven.surefire.Surefire.run(Surefire.java:108)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:265)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:792)
Caused by: Traceback (innermost last):
File "<string>", line 7, in ?
ImportError: cannot import name SurefireTestSet

at org.python.core.Py.ImportError(Py.java:193)
at org.python.core.imp.importFromAs(imp.java:694)
at org.python.core.imp.importFrom(imp.java:667)
at org.python.pycode._pyx0.f$0(<string>:7)
at org.python.pycode._pyx0.call_function(<string>)
at org.python.core.PyTableCode.call(PyTableCode.java:213)
at org.python.core.PyCode.call(PyCode.java:14)
at org.python.core.Py.runCode(Py.java:1182)
at org.python.core.Py.exec(Py.java:1204)
at org.python.util.PythonInterpreter.exec(PythonInterpreter.java:137)
... 14 more
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE

The problem may be caused by recent changes on the surefire classloader... let me know if you can have a look at it.

Show
fabrizio giustina added a comment - Hi Charlie, I tried to integrate your patches, but looks like that tests on the jythonProviderTest don't work properly. After adding the surefire-jython provider and applying your patch to the maven surefire plugin this is what I get when I try running tests: [INFO] Surefire report directory: \jythonProvider.tar\jythonProvider\jythonProviderTest\target\surefire-reports sys-package-mgr : processing new jar, 'C:\repository\m2\jython\jython\2.2-alpha1\jython-2.2-alpha1.jar' org.apache.maven.surefire.booter.SurefireExecutionException: Problem reflecting on class org.python.core.PySystemState; nested exception is java.lang.reflect.InvocationTargetException: null; nested exception is org.apache.maven.surefire.testset.TestSetFailedException: Problem reflecting on class org.python.core.PySystemState; nested exception is java.lang.reflect.InvocationTargetException: null org.apache.maven.surefire.testset.TestSetFailedException: Problem reflecting on class org.python.core.PySystemState; nested exception is java.lang.reflect.InvocationTargetException: null java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.apache.maven.surefire.jython.JythonDirectoryTestSuite.setupInterpreter(JythonDirectoryTestSuite.java:130) at org.apache.maven.surefire.jython.JythonDirectoryTestSuite.locateTestSets(JythonDirectoryTestSuite.java:102) at org.apache.maven.surefire.Surefire.createSuiteFromDefinition(Surefire.java:147) at org.apache.maven.surefire.Surefire.run(Surefire.java:108) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:265) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:792) Caused by: Traceback (innermost last): File "<string>", line 7, in ? ImportError: cannot import name SurefireTestSet at org.python.core.Py.ImportError(Py.java:193) at org.python.core.imp.importFromAs(imp.java:694) at org.python.core.imp.importFrom(imp.java:667) at org.python.pycode._pyx0.f$0(<string>:7) at org.python.pycode._pyx0.call_function(<string>) at org.python.core.PyTableCode.call(PyTableCode.java:213) at org.python.core.PyCode.call(PyCode.java:14) at org.python.core.Py.runCode(Py.java:1182) at org.python.core.Py.exec(Py.java:1204) at org.python.util.PythonInterpreter.exec(PythonInterpreter.java:137) ... 14 more [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE The problem may be caused by recent changes on the surefire classloader... let me know if you can have a look at it.
Hide
Permalink
Charlie Groves added a comment -

Yep, I was depending on SurefireTestSet being on the classpath which no longer seems to be the case. I'll take a look at moving the classloading around so this works.

Show
Charlie Groves added a comment - Yep, I was depending on SurefireTestSet being on the classpath which no longer seems to be the case. I'll take a look at moving the classloading around so this works.
Hide
Permalink
Charlie Groves added a comment -

I've updated the jython provider to work with the classloading changes. You should be able to apply the two patches to their respective projects, build, unpack the tar and run it to see the jython provider in action. If one test passes and one fails in the example project everything is working correctly.

I've been using this plugin at work for the past couple months and it seems pretty solid. I've added a traceback writer that cleans out most of the Jython invocation crud since I initially posted this. It's in the new patch.

Show
Charlie Groves added a comment - I've updated the jython provider to work with the classloading changes. You should be able to apply the two patches to their respective projects, build, unpack the tar and run it to see the jython provider in action. If one test passes and one fails in the example project everything is working correctly. I've been using this plugin at work for the past couple months and it seems pretty solid. I've added a traceback writer that cleans out most of the Jython invocation crud since I initially posted this. It's in the new patch.
Hide
Permalink
Ryan Lea added a comment -

I realise this is 3 years old. From reading through the comments on a few issues: http://jira.codehaus.org/browse/SUREFIRE-292 and http://jira.codehaus.org/browse/SUREFIRE-141 I'm not sure whether this kind of functionality is going to be implemented.

I'm about to start writing a similar provider and modify the surefire-plugin to handle my provider but was wondering if there was actually any kind of direction this project is taking that I should be taking into consideration to ensure that I don't require lots of rework.

Any comments or feedback would be welcomed.

Thanks

Show
Ryan Lea added a comment - I realise this is 3 years old. From reading through the comments on a few issues: http://jira.codehaus.org/browse/SUREFIRE-292 and http://jira.codehaus.org/browse/SUREFIRE-141 I'm not sure whether this kind of functionality is going to be implemented. I'm about to start writing a similar provider and modify the surefire-plugin to handle my provider but was wondering if there was actually any kind of direction this project is taking that I should be taking into consideration to ensure that I don't require lots of rework. Any comments or feedback would be welcomed. Thanks
Hide
Permalink
Karl Palsson added a comment -

To me this sounds perfect, either via this patch, or via http://jira.codehaus.org/browse/SUREFIRE-141 We've started writing tests in jython, but currently it's an entirely separate project, that we copy the built jar over into, I'd love to see it better integrated!

Show
Karl Palsson added a comment - To me this sounds perfect, either via this patch, or via http://jira.codehaus.org/browse/SUREFIRE-141 We've started writing tests in jython, but currently it's an entirely separate project, that we copy the built jar over into, I'd love to see it better integrated!
Hide
Permalink
Kristian Rosenvold added a comment -

Note that surefire-141 has now been fixed.

Show
Kristian Rosenvold added a comment - Note that surefire-141 has now been fixed.
Hide
Permalink
Kristian Rosenvold added a comment -

I am proposing this issue as wontfix. Now that surefire-141 is fixed, it is trivial to write a jython provider that seamlessly integrates with surefire. This provider should be part of the jython community and I really see no reason why it should be included in surefire itself.

Show
Kristian Rosenvold added a comment - I am proposing this issue as wontfix. Now that surefire-141 is fixed, it is trivial to write a jython provider that seamlessly integrates with surefire. This provider should be part of the jython community and I really see no reason why it should be included in surefire itself.
Hide
Permalink
Kristian Rosenvold added a comment -

http://mail-archives.apache.org/mod_mbox/maven-dev/201101.mbox/%3C1295866251.13332.27.camel@chunky%3E

Show
Kristian Rosenvold added a comment - http://mail-archives.apache.org/mod_mbox/maven-dev/201101.mbox/%3C1295866251.13332.27.camel@chunky%3E
Hide
Permalink
Johannes Buchner added a comment -

Take a look at my jython test plugin at http://mavenjython.sourceforge.net/test/

Show
Johannes Buchner added a comment - Take a look at my jython test plugin at http://mavenjython.sourceforge.net/test/

People

  • Assignee:
    Unassigned
    Reporter:
    Charlie Groves
Vote (9)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: