StAX

XMLWriterBase: writeEndElement after writeEmptyElement omits close tag (invalid XML, patch included)

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Labels:
    None
  • Number of attachments :
    1

Description

When used after writeEmptyElement, writeEndElement omits the close tag of the previous element, producing invalid xml.

Since: SVN Rev. 53, 2005-08-31

Steps to reproduce:

writeStartElement("start");
writeEmptyElement("empty");
writeEndElement();

Result: <start><empty/>

Workaround:

writeStartElement("start");
writeEmptyElement("empty");
writeCharacters(""); // closes empty tag
writeEndElement();

Result: <start><empty/></start>

Fix:

--- old\XMLWriterBase.java      2006-01-21 00:25:20.641329600 +0100
+++ new\XMLWriterBase.java      2006-01-21 00:39:27.799483200 +0100
@@ -406,8 +406,9 @@
     public void writeEndElement()
         throws XMLStreamException
     {
-        //boolean wasEmpty = startElementOpened;
-        boolean wasEmpty = isEmpty = isOpen();
+        // shortcut close tag, except if opened with writeEmptyElement
+        boolean wasEmpty = !isEmpty && isOpen();
+        isEmpty = isOpen();
         closeStartElement();
         String prefix = (String) prefixStack.pop();
         String local = (String) localNameStack.pop();
  1. File
    patch.diff
    20/Jan/06 6:53 PM
    0.6 kB
    Karsten Blees

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tatu Saloranta added a comment -

I actually think I fixed this yesterday, before seeing this bug report. Seems to work, to the degree that the matching simple writer test passes.

Show
Tatu Saloranta added a comment - I actually think I fixed this yesterday, before seeing this bug report. Seems to work, to the degree that the matching simple writer test passes.
Hide
Permalink
Tatu Saloranta added a comment -

As per previous comment, fixed in SVN head, should go in 1.2 release.

Show
Tatu Saloranta added a comment - As per previous comment, fixed in SVN head, should go in 1.2 release.

People

  • Assignee:
    Unassigned
    Reporter:
    Karsten Blees
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: