StAX

XMLStreamConstants.CDATA are not getting generated

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Labels:
    None
  • Number of attachments :
    1

Description

XML:
<?xml version="1.0"?>
<foo>
<bar>baz
<cheese id="3"/>
baz
<cheese/>
baz
</bar>
<doc><![CDATA[<foo>]]></doc>
</foo>

Events:
SPACE: [
]
START_ELEMENT: foo:foo
CHARACTERS: [
]
START_ELEMENT: bar:bar
CHARACTERS: [baz
]
START_ELEMENT: cheese:cheese
END_ELEMENT: cheese:cheese
CHARACTERS: [
baz
]
START_ELEMENT: cheese:cheese
END_ELEMENT: cheese:cheese
CHARACTERS: [
baz
]
END_ELEMENT: bar:bar
CHARACTERS: [
]
START_ELEMENT: doc:doc
CHARACTERS: [<foo>]
END_ELEMENT: doc:doc
CHARACTERS: [
]
END_ELEMENT: foo:foo
END_DOCUMENT:

I expect a XMLStreamConstants.CDATA for <![CDATA[<foo>]]> but getting XMLStreamConstants.CHARACTERS instead.

thanks,
dims

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Davanum Srinivas added a comment -

Here's the patch:

Index: src/com/bea/xml/stream/MXParser.java
===================================================================
— src/com/bea/xml/stream/MXParser.java (revision 45)
+++ src/com/bea/xml/stream/MXParser.java (working copy)
@@ -1487,7 +1487,8 @@
return (eventType == XMLStreamConstants.CHARACTERS

eventType == XMLStreamConstants.DTD
eventType == XMLStreamConstants.COMMENT
eventType == XMLStreamConstants.SPACE
+ 		eventType == XMLStreamConstants.SPACE
+ 		eventType == XMLStreamConstants.CDATA
eventType == XMLStreamConstants.ENTITY_REFERENCE);
}

@@ -1680,7 +1681,7 @@
} else

{ if( !usePC && hadCharData ) needsMerging = true; }
  • // if(tokenize) return eventType = XMLStreamConstants.CDATA;
    + if(tokenize) return eventType = XMLStreamConstants.CDATA;
    } else {
    throw new XMLStreamException(
    "unexpected character in markup "+printable(ch),
Show
Davanum Srinivas added a comment - Here's the patch: Index: src/com/bea/xml/stream/MXParser.java =================================================================== — src/com/bea/xml/stream/MXParser.java (revision 45) +++ src/com/bea/xml/stream/MXParser.java (working copy) @@ -1487,7 +1487,8 @@ return (eventType == XMLStreamConstants.CHARACTERS eventType == XMLStreamConstants.DTD eventType == XMLStreamConstants.COMMENT eventType == XMLStreamConstants.SPACE + eventType == XMLStreamConstants.SPACE + eventType == XMLStreamConstants.CDATA eventType == XMLStreamConstants.ENTITY_REFERENCE); } @@ -1680,7 +1681,7 @@ } else { if( !usePC && hadCharData ) needsMerging = true; } // if(tokenize) return eventType = XMLStreamConstants.CDATA; + if(tokenize) return eventType = XMLStreamConstants.CDATA; } else { throw new XMLStreamException( "unexpected character in markup "+printable(ch),
Hide
Permalink
Aleksander Slominski added a comment -

As far as I can tell it is correct behavior according to spec.

Coul dyou provide a way to reproduce problem and how it is dfferent from what you expected?

thanks!

Alek

Show
Aleksander Slominski added a comment - As far as I can tell it is correct behavior according to spec. Coul dyou provide a way to reproduce problem and how it is dfferent from what you expected? thanks! Alek
Hide
Permalink
Davanum Srinivas added a comment -

functionality required is available in sjsxp using the report-cdata-event flag (http://java.sun.com/webservices/docs/1.6/sjsxp/ReleaseNotes.html)

– dims

Show
Davanum Srinivas added a comment - functionality required is available in sjsxp using the report-cdata-event flag ( http://java.sun.com/webservices/docs/1.6/sjsxp/ReleaseNotes.html ) – dims
Hide
Permalink
Davanum Srinivas added a comment -

Here's the output that we need (shows that the patch works!) If you want to introduce a property for us to get the CDATA events, am ok with that.

CHARACTERS: [
]
CHARACTERS: [baz
]
CHARACTERS: [
baz
]
CHARACTERS: [
baz
]
CHARACTERS: [
]
CDATA: [<foo>]
CHARACTERS: [
]

Show
Davanum Srinivas added a comment - Here's the output that we need (shows that the patch works!) If you want to introduce a property for us to get the CDATA events, am ok with that. CHARACTERS: [ ] CHARACTERS: [baz ] CHARACTERS: [ baz ] CHARACTERS: [ baz ] CHARACTERS: [ ] CDATA: [<foo>] CHARACTERS: [ ]
Hide
Permalink
Davanum Srinivas added a comment -

see verifyevents.java for sample code.

Show
Davanum Srinivas added a comment - see verifyevents.java for sample code.
Hide
Permalink
Aleksander Slominski added a comment -

FIXED by implementing optional property "http://java.sun.com/xml/stream/properties/report-cdata-event"
for details see http://www.extreme.indiana.edu/bugzilla/show_bug.cgi?id=231

Show
Aleksander Slominski added a comment - FIXED by implementing optional property "http://java.sun.com/xml/stream/properties/report-cdata-event" for details see http://www.extreme.indiana.edu/bugzilla/show_bug.cgi?id=231
Hide
Permalink
Tatu Saloranta added a comment -

As per Alek's last comment, can this be now resolved?

Also... it'd be good to somehow 'standardize' on such property: I would prefer not using 'sun-specific' name (but rather something referring to either 'javax.xml.stream' package; or the reference implementation), but if it's decided that it's most convenient to use sjsxp one, at least acknowledge it as a de facto standard.
Any objections to creating a wiki page for such "well-known" de facto standard properties? Woodstox implements this feature as well, and could easily add an alias so this would become most useful to developers.

Show
Tatu Saloranta added a comment - As per Alek's last comment, can this be now resolved? Also... it'd be good to somehow 'standardize' on such property: I would prefer not using 'sun-specific' name (but rather something referring to either 'javax.xml.stream' package; or the reference implementation), but if it's decided that it's most convenient to use sjsxp one, at least acknowledge it as a de facto standard. Any objections to creating a wiki page for such "well-known" de facto standard properties? Woodstox implements this feature as well, and could easily add an alias so this would become most useful to developers.
Hide
Permalink
Tatu Saloranta added a comment -

I verified that the property works (it was needed by couple of unit tests, to test coalescing appropriately), resolving.

Show
Tatu Saloranta added a comment - I verified that the property works (it was needed by couple of unit tests, to test coalescing appropriately), resolving.

People

  • Assignee:
    Unassigned
    Reporter:
    Davanum Srinivas
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: