Code best practices

Before vote will occur :

• Could you please re-read http://docs.codehaus.org/display/SONAR/Developer+guide#Developerguide-Codeformatting - replace tabs by two spaces.
• The expression $ {pom.groupId}

  is deprecated. Please use $

  {project.groupId}

  instead.

• It's not recommended to have "repositories" section in pom.xml, so I wonder if it really required?
• Configuration of sonar-packaging-maven-plugin should be removed from sonar-jmeter-plugin. Use property "sonar.pluginClass". And don't set plugin key - it would be generated automatically from artifactId. See http://docs.codehaus.org/display/SONAR/sonar-packaging-maven-plugin
• Configuration for maven-compiler-plugin and "project.build.sourceEncoding" should be removed from POMs - see http://docs.codehaus.org/display/SONAR/Sonar+Plugins+Forge+Parent+POM
• Common stuff (like organization, license, developers) should be declared in parent ( org.codehaus.sonar-plugins.jmeter:parent ) and you can remove version from sub-projects, since anyway they should be released together.
• Use package "org.sobar.plugins.jmeter".