Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: WEB-0.1
    • Fix Version/s: WEB-1.0
    • Component/s: Web
    • Labels:
      None
    • Number of attachments :
      0

      Activity

      Hide
      Evgeny Mandrikov added a comment - - edited

      Hi Matthijs,

      In fact you incorrectly migrated to parent-7, because your pom mentions Apache license, but headers in source files LGPL. Moreover you defined sonar-packaging-maven-plugin version 0.2, but should be used 1.0. So you should do following:

      • specify property "license.name" with value "AL2" - see How to configure License
      • remove file "src/license-header.txt"
      • remove section pluginManagement
      • specify property "sonar.pluginName" with value "Web" and property "sonar.pluginClass" with value "org.sonar.plugins.web.WebPlugin"

      Also can I ask you to reformat pom.xml according to Sonar code convention - replace 4 spaces by 2 spaces ?

      Show
      Evgeny Mandrikov added a comment - - edited Hi Matthijs, In fact you incorrectly migrated to parent-7, because your pom mentions Apache license, but headers in source files LGPL. Moreover you defined sonar-packaging-maven-plugin version 0.2, but should be used 1.0. So you should do following: specify property "license.name" with value "AL2" - see How to configure License remove file "src/license-header.txt" remove section pluginManagement specify property "sonar.pluginName" with value "Web" and property "sonar.pluginClass" with value "org.sonar.plugins.web.WebPlugin" Also can I ask you to reformat pom.xml according to Sonar code convention - replace 4 spaces by 2 spaces ?
      Hide
      Matthijs Galesloot added a comment -

      Thanks for the detailed advices. This is fixed now.

      Show
      Matthijs Galesloot added a comment - Thanks for the detailed advices. This is fixed now.
      Hide
      Evgeny Mandrikov added a comment -

      Could you also remove property "sonar.pluginKey", indeed it's not needed because key would be transformed from artifactId ?

      Show
      Evgeny Mandrikov added a comment - Could you also remove property "sonar.pluginKey", indeed it's not needed because key would be transformed from artifactId ?
      Hide
      Matthijs Galesloot added a comment -

      pluginKey removed.

      Please note I had copied this from cutoff plugin
      <sonar.pluginKey>cutoff</sonar.pluginKey>

      Show
      Matthijs Galesloot added a comment - pluginKey removed. Please note I had copied this from cutoff plugin <sonar.pluginKey>cutoff</sonar.pluginKey>
      Hide
      Evgeny Mandrikov added a comment -

      I know about cutoff - this is because cutoff uses parent-6 and older version of sonar-packaging-maven-plugin

      Show
      Evgeny Mandrikov added a comment - I know about cutoff - this is because cutoff uses parent-6 and older version of sonar-packaging-maven-plugin

        People

        • Assignee:
          Matthijs Galesloot
          Reporter:
          Matthijs Galesloot
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: