Add a check for Maven POM code convention

Great, I did not know these conventions.
Do you know how can we check them ? Are there any lib at Apache ?

Hi all, I think it would be better to automatically reorder and reformat pom.xml - see http://jira.codehaus.org/browse/MOJO-928

From Sonar point of view, I think it is better to raise a warning/error when convention is not followed. I don't want that Sonar change the pom.xml of the project.

Having a Maven plugin to perform the change is a good thing but is the responsibility of each project to actually run it. Sonar is the solution in corporate environment to check all projects are following the rule.

So, I think that such functionality should be realized as a plugin.
Moreover it can be a good start point for plugin, which can validate not only pom.xml (eg. jboss-app.xml, web.xml and so on).
What do you think, guys?

Do you thing that it is possible to use the xml-maven-plugin (http://mojo.codehaus.org/xml-maven-plugin) to validate xml files (POM, ...) against coding rules defined through an XSD.

Hi Christophe,

I never used this plugin, but looks like it can check validity of xml file against an XSD.
But returning to original issue - validity of xml isn't the same as compliance with POM Code Convention.

Evgeny,

POM Code convention is a POM elements ordering, so you can defined it using an XSD. In the default POM XSD (http://maven.apache.org/xsd/maven-4.0.0.xsd), all elements are defined inside a 'xsd:all'. If you replace it by a 'xsd:sequence' and order elements according to POM Code conventions, you check the compliance with POM Code Convention.

Good point, Christophe.

I've moved this issue to Sonar Plugins project, because we want to decouple Sonar core from Maven in future.

In reply to comment #5:
> Do you thing that it is possible to use the xml-maven-plugin
> (http://mojo.codehaus.org/xml-maven-plugin) to validate xml files (POM, ...)
> against coding rules defined through an XSD.
Just for historical reference, I get it to work with this configuration:

			<plugin>
				<groupId>org.codehaus.mojo</groupId>
				<artifactId>xml-maven-plugin</artifactId>
				<version>1.0</version>
				<executions>
					<execution>
						<phase>validate</phase>
						<goals>
							<goal>validate</goal>
						</goals>
					</execution>
				</executions>
				<configuration>
					<validationSets>
						<validationSet>
							<dir>${project.basedir}</dir>
							<systemId>http://my.company.server/maven-4.0.0.xsd</systemId>
							<includes>
								<include>pom.xml</include>
							</includes>
						</validationSet>
					</validationSets>
				</configuration>
			</plugin>

The maven-4.0.0.xsd was edited to follow the POM Code Convention Rules.