SonarQube Plugins
  1. SonarQube Plugins
  2. SONARPLUGINS-3024

LibraryDependencyCheck : Update title, description and violation message and make it multiple cardinality

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WEB-2.0
    • Component/s: Web
    • Labels:
      None
    • Number of attachments :
      0

      Issue Links

        Activity

        Hide
        Dinesh Bolkensteyn added a comment -

        Done

        Show
        Dinesh Bolkensteyn added a comment - Done
        Hide
        Freddy Mallet added a comment -

        title and description have been correctly updated but I don't manage to get any violation with this coding rule.

        Show
        Freddy Mallet added a comment - title and description have been correctly updated but I don't manage to get any violation with this coding rule.
        Hide
        Dinesh Bolkensteyn added a comment -

        Well spotted Freddy!

        In fact properties do not work on new checks:

        Previously, checks were using getters and setters for Sonar properties, and no one knew exactly why this was working.

        I simply removed those methods, and all seemed to work fine.

        But in fact it does not, because the Web plugin had some logic to instantiate the checks itself (based on the profile), instead of relying on Sonar to do so.
        It then used reflection to call the properties setter methods.

        Long story short, this will take a bit of time to fix.

        Show
        Dinesh Bolkensteyn added a comment - Well spotted Freddy! In fact properties do not work on new checks: Previously, checks were using getters and setters for Sonar properties, and no one knew exactly why this was working. I simply removed those methods, and all seemed to work fine. But in fact it does not, because the Web plugin had some logic to instantiate the checks itself (based on the profile), instead of relying on Sonar to do so. It then used reflection to call the properties setter methods. Long story short, this will take a bit of time to fix.
        Hide
        Dinesh Bolkensteyn added a comment - - edited

        Should be fixed now!

        Show
        Dinesh Bolkensteyn added a comment - - edited Should be fixed now!
        Hide
        Dinesh Bolkensteyn added a comment -

        Well now it's fixed for real!

        Show
        Dinesh Bolkensteyn added a comment - Well now it's fixed for real!
        Hide
        Freddy Mallet added a comment -

        Manually tested !

        Show
        Freddy Mallet added a comment - Manually tested !

          People

          • Assignee:
            Dinesh Bolkensteyn
            Reporter:
            Dinesh Bolkensteyn
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: