Rule: Function argument names should be unique

title

Function argument names should be unique

description

Function arguments should all have different names to prevent any ambiguity. Indeed, if arguments have the same name, the last duplicated argument hides all the previous arguments with the same name (those previous arguments remain available through <code>arguments[i]</code>, so they're not completely inaccessible). This hiding makes no sense, clearly reduces understandability and maintainability, and obvioulsy can be error prone.

Furthermore, in JavaScript strict mode, declaring arguments with the same name produces an error.

The following code snippet illustrates this rule :

function compute(a, a, c) { // non-compliant
  ...
}

function computeBis(a, b, c) { // compliant
  ...
}

message

Rename or remove duplicate function argument '

'.

severity

Critical

in Sonar way?

Yes