Erlang: make rules localizable

Hi,

I do not now what did I wrong, but when I try to start up sonar it says:

NFO | jvm 1 | 2012/12/03 10:09:51 | 2012-12-03 10:09:51.849:WARN::Failed startup of context org.mortbay.jetty.webapp.WebAppContext@3d6a2c7b

INFO | jvm 1 | 2012/12/03 10:09:51 | org.sonar.api.utils.SonarException: The following rule (repository: erlang) must have a name: Rule[id=<null>,name=<null>,key=BlockSeparatorCharacter,configKey=BlockSeparatorCharacter,plugin=erlang,enabled=true,severity=MAJOR,cardinality=SINGLE]
INFO | jvm 1 | 2012/12/03 10:09:51 | at org.sonar.server.startup.RegisterRules.validateRule(RegisterRules.java:123)
INFO | jvm 1 | 2012/12/03 10:09:51 | at org.sonar.server.startup.RegisterRules.registerRepository(RegisterRules.java:103)
INFO | jvm 1 | 2012/12/03 10:09:51 | at org.sonar.server.startup.RegisterRules.start(RegisterRules.java:66)
INFO | jvm 1 | 2012/12/03 10:09:51 | at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
INFO | jvm 1 | 2012/12/03 10:09:51 | at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
INFO | jvm 1 | 2012/12/03 10:09:51 | at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
INFO | jvm 1 | 2012/12/03 10:09:51 | at java.lang.reflect.Method.invoke(Method.java:616)
INFO | jvm 1 | 2012/12/03 10:09:51 | at org.picocontainer.lifecycle.ReflectionLifecycleStrategy.invokeMethod(ReflectionLifecycleStrategy.java:110)

but the erlang.properties seems fine, it is based on the js plugin... can u help me to solve this?

In the unit test of the profile the name of the rule is filled... (ErlangProfileTest)

Plugin key should be "erlang", so you should change https://github.com/SonarCommunity/sonar-erlang/blob/4be6311449855a7edf80d3feb91898c5aa78cde9/sonar-erlang-plugin/pom.xml#L20

That was it, thanks!!!

Hi, one more question. I have the dialyzer rule set, they are in a rules.xml. I could localize it in the same way, creating an erlang.properties in the plugin's resources, but in this case it will conflict with the checks' erlang.properties... It would be weird if I had to define the names in the check, but the descriptions and the rule xml would stay in the plugin... or migrate everything to the checks?

I would prefer to leave dialyzer rules not localizable, because in long term we should get rid of dependency on third-party tool and replace rules by our own.

sorry, I accidentally closed it