Rule NestedIfDepthCheck should not produce false-positive in case of 'if-else-if'

According to "https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Statements/if...else" "else if" is just a "nested if"

Hi guys,

Formally speaking Eriks is right ( together with Mozilla ) - from an AST (abstract syntax tree) point of view - "else if" construction clearly is a nested "if". But from a developer point of view (i.e. user of Sonar) this seems weird.

And indeed I had a discussion with another member of SonarSource language team - Dinesh Bolkensteyn. We came to conclusion that this rule with parameter max=1 should behave as shown below:

if (...) { // no violation, because level is 1
  if (...) { // violation, because level is 2
  }
} else if (...) { // no violation, because level still 1
  if (...) { // violation, because level is 2
  }
} else {
  if (...) { // violation, because level is 2
  }
}

i.e. "else if" construction should not increase level.

Also should be noted that current behaviour is exactly the same as behaviour of PMD rule for Java, whereas we want to behave as Checkstyle rule for Java.

Works well Evgeny, could you just change the following thing in the description :

• "Deeply nested if statements are hard to read." by "Deeply nested if statements are hard to read and so to maintain."
• "The following code snippet illustrates this rule :" by "The following code snippet illustrates this rule with the default threshold of 3 :"

Done.

Manually tested !