Sonar Plugins

Rule AlwaysUseCurlyBracesCheck should not produce false-positive in case of 'if-else-if'

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JAVASCRIPT-1.0
  • Fix Version/s: JAVASCRIPT-1.1
  • Component/s: JavaScript
  • Labels:
    None
  • Environment:
    OS X 10.7.4, Sonar-3.1.1, JavaScript plugin 1.0
  • Number of attachments :
    1

Description

(Minimal) code snippet which triggers the false positive is attached.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. SONARPLUGINS-2269 "Curly Braces" rule returns false-positives

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Mandrikov added a comment -

Related discussion - http://markmail.org/message/m3qzojcuut3isc4u

Show
Evgeny Mandrikov added a comment - Related discussion - http://markmail.org/message/m3qzojcuut3isc4u
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !
Hide
Permalink
David M. Karr added a comment -

I installed version 1.1 of the plugin, which has this fix, but I'm still seeing false positives for this rule.

For instance, this line is getting this warning:

var files = 0; for ( file in $this.jsonData )

{ if($this.jsonData.hasOwnProperty(file)) files++; }
Show
David M. Karr added a comment - I installed version 1.1 of the plugin, which has this fix, but I'm still seeing false positives for this rule. For instance, this line is getting this warning: var files = 0; for ( file in $this.jsonData ) { if($this.jsonData.hasOwnProperty(file)) files++; }
Hide
Permalink
Evgeny Mandrikov added a comment -

In this case it's not a false positive. This rule expects that code is written as:

var files = 0; for ( file in $this.jsonData ) { if ($this.jsonData.hasOwnProperty(file)) { files++; } }
Show
Evgeny Mandrikov added a comment - In this case it's not a false positive. This rule expects that code is written as: var files = 0; for ( file in $ this .jsonData ) { if ($ this .jsonData.hasOwnProperty(file)) { files++; } }

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Steven Looman
Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: