SonarQube Plugins

The Javascript analyser doesn't support the HTML comment embedded into the javascript source code

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JAVASCRIPT-1.0
  • Fix Version/s: JAVASCRIPT-1.1
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Description

In the following case a lexing issue is raised whereas this should not be the case :

13:48:50  ---------------
13:48:50    168 }
13:48:50    169 function closePopupOver()
13:48:50    170   {
13:48:50    171    $('#mask').hide();
13:48:50    172    $('.window').hide();
13:48:50    173    showDropdowns();
13:48:50    174   }
13:48:50    175
13:48:50    --> <!-- This is a comment -->
13:48:50    177 function selectRadioButton()
13:48:50    178 {
13:48:50    179 document.getElementById('ModalPopupDivQuote').innerHTML=""

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-2290 Rule: Do not use HTML comments, because they are not part of EcmaScript specification

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Mandrikov added a comment -

Freddy, where this code was obtained? The thing is that according to ECMAScript standard there is only two types of comments : "//" and "/* .. */".

Show
Evgeny Mandrikov added a comment - Freddy, where this code was obtained? The thing is that according to ECMAScript standard there is only two types of comments : "//" and "/* .. */".
Hide
Permalink
Freddy Mallet added a comment -

Based on customer feedback which didn't manage anymore to analyse its javascript source files with version 1.0 of the Javascript plugin. See http://www.javascripter.net/faq/comments.htm.

Show
Freddy Mallet added a comment - Based on customer feedback which didn't manage anymore to analyse its javascript source files with version 1.0 of the Javascript plugin. See http://www.javascripter.net/faq/comments.htm .
Hide
Permalink
Freddy Mallet added a comment -

Works well Evgeny, could you just also update the javascript source code colorizer ?

Show
Freddy Mallet added a comment - Works well Evgeny, could you just also update the javascript source code colorizer ?
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment - - edited

Manually tested !

The colorization of HTML comment is not done in the toolkit but that's not an issue.

Show
Freddy Mallet added a comment - - edited Manually tested ! The colorization of HTML comment is not done in the toolkit but that's not an issue.

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Freddy Mallet
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: