Sonar Plugins

Rule: Detect commented-out lines of code

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: FLEX-1.1
  • Component/s: Flex
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1907 Provide Flex rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. SONARPLUGINS-1956 Improve detection of commented-out lines of code

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Fabrice Bellingard added a comment -

Works well, but I've noticed a false-positive that could be avoided IMO: the following line is detected as commented-out code

// --------------------------------------------------------------------

For example, on "org/as3commons/lang/ClassUtils.as" of "AS3Commons Lang" (lines 353 and 357).

There's also the false-positive due to the last semi-colon of the ASL v2 header, but I don't know if something can be done on this case for now ( ?).

Show
Fabrice Bellingard added a comment - Works well, but I've noticed a false-positive that could be avoided IMO: the following line is detected as commented-out code // -------------------------------------------------------------------- For example, on "org/as3commons/lang/ClassUtils.as" of "AS3Commons Lang" (lines 353 and 357). There's also the false-positive due to the last semi-colon of the ASL v2 header, but I don't know if something can be done on this case for now ( ?).
Hide
Permalink
Evgeny Mandrikov added a comment -

Fabrice, we have exactly the same limitations in plugins for other languages, so in fact I would prefer to postpone this for now and sort out later for all plugins. What is your feeling?

Show
Evgeny Mandrikov added a comment - Fabrice, we have exactly the same limitations in plugins for other languages, so in fact I would prefer to postpone this for now and sort out later for all plugins. What is your feeling?
Hide
Permalink
Fabrice Bellingard added a comment -

OK, I'm fine with this, as long as we create a ticket for the Flex plugin so that users can see that it's a known limitation.

Show
Fabrice Bellingard added a comment - OK, I'm fine with this, as long as we create a ticket for the Flex plugin so that users can see that it's a known limitation.
Hide
Permalink
Fabrice Bellingard added a comment -

Manually tested

Show
Fabrice Bellingard added a comment - Manually tested
Hide
Permalink
Evgeny Mandrikov added a comment -

Ticket created - SONARPLUGINS-1956

Show
Evgeny Mandrikov added a comment - Ticket created - SONARPLUGINS-1956
Hide
Permalink
Evgeny Mandrikov added a comment -

Closed without integration test

Show
Evgeny Mandrikov added a comment - Closed without integration test

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: