Sonar Plugins

Rule: Avoid deeply nested if statements

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Description

<p>
Deeply nested if statements are hard to read. An example deeply nested if is this:
</p>

<pre>
function sayHello() {
  if (true) {
    if (true) {
      if (true) {
        if (true) { // NOK
          return;
        } else {
          return;
        }
      }
    }
  }
}
</pre>

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Mandrikov added a comment -

Hi Eriks, FYI we plan to start vote for release at the end of this week, so actually would be better to finalize all current activities than start work on new ones

Show
Evgeny Mandrikov added a comment - Hi Eriks, FYI we plan to start vote for release at the end of this week, so actually would be better to finalize all current activities than start work on new ones
Hide
Permalink
Eriks Nukis added a comment -

Implemented in https://github.com/eriksnukis/javascript/commit/b64ad7cfada0e1bfdfad222870a9c26039a6f6a8

Show
Eriks Nukis added a comment - Implemented in https://github.com/eriksnukis/javascript/commit/b64ad7cfada0e1bfdfad222870a9c26039a6f6a8
Hide
Permalink
Evgeny Mandrikov added a comment -

Has been merged.

Show
Evgeny Mandrikov added a comment - Has been merged.
Hide
Permalink
Freddy Mallet added a comment -

This check logs a violation for each if statement whose level is greater than this expected threshold. So if you have 7 nested statements and if the threshold is 3, you'll get 4 violations instead of only 1.

In the description, replace "An example deeply nested if is this:" by "The following code snippet illustrates this rule:"

Show
Freddy Mallet added a comment - This check logs a violation for each if statement whose level is greater than this expected threshold. So if you have 7 nested statements and if the threshold is 3, you'll get 4 violations instead of only 1. In the description, replace "An example deeply nested if is this:" by "The following code snippet illustrates this rule:"
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment -

I still have the issue Evgeny

Show
Freddy Mallet added a comment - I still have the issue Evgeny
Hide
Permalink
Evgeny Mandrikov added a comment -

I thought that you just made an explanation and asked for change of message. Now I see that you described problem, which should be fixed

Show
Evgeny Mandrikov added a comment - I thought that you just made an explanation and asked for change of message. Now I see that you described problem, which should be fixed
Hide
Permalink
Evgeny Mandrikov added a comment -

Fixed.

Show
Evgeny Mandrikov added a comment - Fixed.
Hide
Permalink
Freddy Mallet added a comment -

YES, manually tested !

Show
Freddy Mallet added a comment - YES, manually tested !

People

  • Assignee:
    Eriks Nukis
    Reporter:
    Eriks Nukis
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: