Sonar Plugins

Rule: Avoid trailing comma in array and object literals

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1788 Provide JavaScript rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Freddy Mallet added a comment - - edited

Works well even if it would be better to report the violation on the line where the trailing comma is located and not on the array or object declaration.

Could you extend the description as follows :

<p>Most browsers do support trailing comma but that's not the case for Internet Explorer for which a meaningless error is thrown for most IE versions.</p>

<p>
The following code snippet illustrates this rule :
</p>

<pre>
var settings = {
    'foo'  : oof,
    'bar' : rab,    <- trailing comma
};
</pre>
Show
Freddy Mallet added a comment - - edited Works well even if it would be better to report the violation on the line where the trailing comma is located and not on the array or object declaration. Could you extend the description as follows : <p>Most browsers do support trailing comma but that's not the case for Internet Explorer for which a meaningless error is thrown for most IE versions.</p> <p> The following code snippet illustrates this rule : </p> <pre> var settings = { 'foo' : oof, 'bar' : rab, <- trailing comma }; </pre>
Hide
Permalink
Freddy Mallet added a comment -

Moreover the default severity of this rule should be blocker.

Show
Freddy Mallet added a comment - Moreover the default severity of this rule should be blocker.
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested

Show
Freddy Mallet added a comment - Manually tested

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: