SonarQube Plugins

Rule: Only while/do/for statements can be labelled

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1788 Provide JavaScript rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Mandrikov added a comment -

Freddy, could you please suggest description for this rule?

Show
Evgeny Mandrikov added a comment - Freddy, could you please suggest description for this rule?
Hide
Permalink
Freddy Mallet added a comment - - edited

Here is a proposal :

<p>Any Javascript statement can be identified by a label but those labels are only useful on 'while', 'do-while' and 'for' statements. If such label is used on a different statement this is mistake.</p>

<p>Here </p>

<pre>
var x = 0;  
var z = 0  
labelCancelLoops: while (true) {    //OK
    console.log("Outer loops: " + x);  
    wrongLabel : x += 1;            //NOK
    z = 1;  
    while (true) {  
        console.log("Inner loops: " + z);  
        z += 1;  
        if (z === 10 && x === 10) {  
            break labelCancelLoops;
        } else if (z === 10) {  
            break;  
        }  
    }  
}
</pre>
Show
Freddy Mallet added a comment - - edited Here is a proposal : <p>Any Javascript statement can be identified by a label but those labels are only useful on 'while', 'do-while' and 'for' statements. If such label is used on a different statement this is mistake.</p> <p>Here </p> <pre> var x = 0; var z = 0 labelCancelLoops: while (true) { //OK console.log("Outer loops: " + x); wrongLabel : x += 1; //NOK z = 1; while (true) { console.log("Inner loops: " + z); z += 1; if (z === 10 && x === 10) { break labelCancelLoops; } else if (z === 10) { break; } } } </pre>
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: