Sonar Plugins

Rule: Avoid doing assignments in the condition part of if/while/for statements

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1788 Provide JavaScript rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Mandrikov added a comment -

Freddy, could you please suggest description for this rule?

Show
Evgeny Mandrikov added a comment - Freddy, could you please suggest description for this rule?
Hide
Permalink
Freddy Mallet added a comment - - edited 
<p>Doing an assignment in the condition part of a 'if', 'while' or 'for' statement is highly not recommended for the two following reasons :/p>

<ul>
<li>The assignment is perhaps a bug as the '=' operator might have been used in place of the '==' operator</li>
<li>If this is not a bug, this is highly error prone as another developer might read '==' instead of '=' while trying to maintain the source code</li>
</ul>

<pre>
if(dayNumber = getClickedDayNumber(dayInfo))   //BUG
{
    alert("day number found : " + dayNumber);
}
</pre>
Show
Freddy Mallet added a comment - - edited <p>Doing an assignment in the condition part of a 'if', 'while' or 'for' statement is highly not recommended for the two following reasons :/p> <ul> <li>The assignment is perhaps a bug as the '=' operator might have been used in place of the '==' operator</li> <li>If this is not a bug, this is highly error prone as another developer might read '==' instead of '=' while trying to maintain the source code</li> </ul> <pre> if(dayNumber = getClickedDayNumber(dayInfo)) //BUG { alert("day number found : " + dayNumber); } </pre>
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment -

Works well but the violation message should be "Remove this assignment from the expression"

Show
Freddy Mallet added a comment - Works well but the violation message should be "Remove this assignment from the expression"
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested

Show
Freddy Mallet added a comment - Manually tested

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: