Sonar Plugins

Rule: Avoid usage of with statement

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1788 Provide JavaScript rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-2508 Rule : Source should comply with the javascript strict mode

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Evgeny Mandrikov made changes -
Field Original Value New Value
Link This issue depends upon SONARPLUGINS-1788 [ SONARPLUGINS-1788 ]
Evgeny Mandrikov made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Eriks Nukis [ eriks.nukis ] Freddy Mallet [ freddy.mallet ]
Resolution Fixed [ 1 ]
Hide
Permalink
Freddy Mallet added a comment - - edited

Manually tested !

Extend the description with the following section :

<p>The with statement was intended to provide a shorthand in accessing properties in deeply nested objects. Unfortunately, it behaves very badly when setting new properties. Never use the with statement. Use a var instead.</p>

<pre>
var ooo.eee.oo.ah_ah.ting.tang.walla.walla.bing = true;
var ooo.eee.oo.ah_ah.ting.tang.walla.walla.bang = true;
</pre>

instead of 

<pre>
with (ooo.eee.oo.ah_ah.ting.tang.walla.walla) {
    bing = true;
    bang = true;
}
</pre>
Show
Freddy Mallet added a comment - - edited Manually tested ! Extend the description with the following section : <p>The with statement was intended to provide a shorthand in accessing properties in deeply nested objects. Unfortunately, it behaves very badly when setting new properties. Never use the with statement. Use a var instead.</p> <pre> var ooo.eee.oo.ah_ah.ting.tang.walla.walla.bing = true; var ooo.eee.oo.ah_ah.ting.tang.walla.walla.bang = true; </pre> instead of <pre> with (ooo.eee.oo.ah_ah.ting.tang.walla.walla) { bing = true; bang = true; } </pre>
Freddy Mallet made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Freddy Mallet [ freddy.mallet ] Evgeny Mandrikov [ godin ]
Hide
Permalink
Evgeny Mandrikov added a comment -

I believe that description should be like http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#with___%7B%7D

Show
Evgeny Mandrikov added a comment - I believe that description should be like http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#with___%7B%7D
Evgeny Mandrikov made changes -
Status Reopened [ 4 ] In Progress [ 3 ]
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Evgeny Mandrikov made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Assignee Evgeny Mandrikov [ godin ] Freddy Mallet [ freddy.mallet ]
Resolution Fixed [ 1 ]
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !
Freddy Mallet made changes -
Assignee Freddy Mallet [ freddy.mallet ] Evgeny Mandrikov [ godin ]
Evgeny Mandrikov made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Evgeny Mandrikov made changes -
Link This issue relates to SONARPLUGINS-2508 [ SONARPLUGINS-2508 ]

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: