jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Sonar Plugins
  • Sonar Plugins
  • SONARPLUGINS-1812

Rule: One statement per line

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1788 Provide JavaScript rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Dinesh Bolkensteyn added a comment - 14/May/12 1:16 AM

Looks good to me (didn't test it though), well done for the re-use of the generic check

However I believe it would be better to go for internationalization right away, and provide an example, as we do on the other plugin (and thereby really making it a first class plugin ).

Show
Dinesh Bolkensteyn added a comment - 14/May/12 1:16 AM Looks good to me (didn't test it though), well done for the re-use of the generic check However I believe it would be better to go for internationalization right away, and provide an example, as we do on the other plugin (and thereby really making it a first class plugin ).
Hide
Permalink
Evgeny Mandrikov added a comment - 14/May/12 1:26 AM

Indeed Dinesh - I agree that we should improve names and descriptions. This wasn't done, because of lack of time

About internationalization - this might mean upgrade of minimal required version of Sonar, so with Freddy we decided to postpone this, however I'll give it a try before release.

Show
Evgeny Mandrikov added a comment - 14/May/12 1:26 AM Indeed Dinesh - I agree that we should improve names and descriptions. This wasn't done, because of lack of time About internationalization - this might mean upgrade of minimal required version of Sonar, so with Freddy we decided to postpone this, however I'll give it a try before release.
Hide
Permalink
Freddy Mallet added a comment - 14/May/12 9:31 AM - edited

Manually tested, could you just update the description with the following lines :

<p>
The following code snippet illustrates this rule :
</p>

<pre>
    this.firstParam = "something";this.secondParam = "somethingElse";     //NOK as there are two statements
</pre>
Show
Freddy Mallet added a comment - 14/May/12 9:31 AM - edited Manually tested, could you just update the description with the following lines : <p> The following code snippet illustrates this rule : </p> <pre> this.firstParam = "something";this.secondParam = "somethingElse"; //NOK as there are two statements </pre>
Hide
Permalink
Evgeny Mandrikov added a comment - 16/May/12 2:52 AM

Done.

Show
Evgeny Mandrikov added a comment - 16/May/12 2:52 AM Done.
Hide
Permalink
Freddy Mallet added a comment - 18/May/12 6:45 AM

Manually tested !

Show
Freddy Mallet added a comment - 18/May/12 6:45 AM Manually tested !

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (0)

Dates

  • Created:
    12/May/12 1:12 AM
    Updated:
    22/May/12 4:19 AM
    Resolved:
    16/May/12 2:52 AM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.