Sonar Plugins

Rule: Line too long

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JAVASCRIPT-1.0
  • Component/s: JavaScript
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. SONARPLUGINS-1788 Provide JavaScript rule engine based on SSLR

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Freddy Mallet added a comment -

Works well Evgeny, could you just change the violation message as follows :

"The line contains x characters which is greater that y authorized"

Show
Freddy Mallet added a comment - Works well Evgeny, could you just change the violation message as follows : "The line contains x characters which is greater that y authorized"
Hide
Permalink
Evgeny Mandrikov added a comment -

Done.

Show
Evgeny Mandrikov added a comment - Done.
Hide
Permalink
Freddy Mallet added a comment -

In fact Evgeny, looks like we fire the violation as soon as we encounter the first token exceeding the threshold.

So with a line whose last character is at column 132 we can have the following violation message :

"The line contains 83 characters which is greater than 80 authorized."

Show
Freddy Mallet added a comment - In fact Evgeny, looks like we fire the violation as soon as we encounter the first token exceeding the threshold. So with a line whose last character is at column 132 we can have the following violation message : "The line contains 83 characters which is greater than 80 authorized."
Hide
Permalink
Evgeny Mandrikov added a comment -

You're right and I guess that this was a reason of a message, which you asked to change I'll take a look on that.

Show
Evgeny Mandrikov added a comment - You're right and I guess that this was a reason of a message, which you asked to change I'll take a look on that.
Hide
Permalink
Evgeny Mandrikov added a comment -

Should be fixed now.

Show
Evgeny Mandrikov added a comment - Should be fixed now.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: