SonarQube Plugins
  1. SonarQube Plugins
  2. SONARPLUGINS-1777

Property "skipSanityChecks" prevents usage of plugin's default properties like "license.skip" and "animal.sniffer.skip"

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: PARENT-12
    • Fix Version/s: PARENT-14
    • Component/s: Parent
    • Labels:
      None
    • Number of attachments :
      0

      Activity

      Hide
      Eric Hartmann added a comment -

      Fixed in #5521
      Locally tested with SCM Activity plugin.
      Now we can override each SanityChecks individually :

      • skipLicenseChecks for skipping licenses header checks
      • skipAnimalSnifferChecks for skipping animal sniffer checks

      By default both variables are initialized with skipSanityChecks value (false)

      Show
      Eric Hartmann added a comment - Fixed in #5521 Locally tested with SCM Activity plugin. Now we can override each SanityChecks individually : skipLicenseChecks for skipping licenses header checks skipAnimalSnifferChecks for skipping animal sniffer checks By default both variables are initialized with skipSanityChecks value (false)
      Hide
      Evgeny Mandrikov added a comment -

      IMO goal of this ticket is to allow usage of a standard plugin properties like "license.skip" instead of introduction of a new ones. Rationale - is to make possible to use maven-bash-completion instead of remembering new properties.
      If you want and if no hurry, then I can take a look on this a bit later.

      Show
      Evgeny Mandrikov added a comment - IMO goal of this ticket is to allow usage of a standard plugin properties like "license.skip" instead of introduction of a new ones. Rationale - is to make possible to use maven-bash-completion instead of remembering new properties. If you want and if no hurry, then I can take a look on this a bit later.
      Hide
      Eric Hartmann added a comment -

      Evgeny, I did not find any simple solution to keep license.skip or animal.sniffer.skip properties and use a skipSanityChecks to control them also.
      So I came back to my first solution that's simple and works.

      Maybe profiles may be a solution, but I make the pom.xml quite more complex for me.

      So I let you either look at it or resolved it.

      Show
      Eric Hartmann added a comment - Evgeny, I did not find any simple solution to keep license.skip or animal.sniffer.skip properties and use a skipSanityChecks to control them also. So I came back to my first solution that's simple and works. Maybe profiles may be a solution, but I make the pom.xml quite more complex for me. So I let you either look at it or resolved it.
      Hide
      Evgeny Mandrikov added a comment -

      Done in r5584: introduced new profile skipSanityChecks, which can be activated via property 'skipSanityChecks' (so no changes in behaviour) and which allows to use standard properties "animal.sniffer.skip" and "license.skip" alone.

      Eric, could you please verify this on your side?

      Show
      Evgeny Mandrikov added a comment - Done in r5584: introduced new profile skipSanityChecks, which can be activated via property 'skipSanityChecks' (so no changes in behaviour) and which allows to use standard properties "animal.sniffer.skip" and "license.skip" alone. Eric, could you please verify this on your side?
      Hide
      Eric Hartmann added a comment -

      Evgeny, the drawback with this solution is that as soon as the property skipSanityChecks is defined to any value. The sanity checks are bypassed.
      For instance using -DskipSanityChecks=false will skip the checks.

      Show
      Eric Hartmann added a comment - Evgeny, the drawback with this solution is that as soon as the property skipSanityChecks is defined to any value. The sanity checks are bypassed. For instance using -DskipSanityChecks=false will skip the checks.
      Hide
      Evgeny Mandrikov added a comment -

      After r5604 behaviour is :

      • by default check
      • "-DskipSanityChecks=false" => check
      • "-DskipSanityChecks=true" => skip
      • "-DskipSanityChecks" => skip
      • "-PskipSanityChecks" => skip
      Show
      Evgeny Mandrikov added a comment - After r5604 behaviour is : by default check "-DskipSanityChecks=false" => check "-DskipSanityChecks=true" => skip "-DskipSanityChecks" => skip "-PskipSanityChecks" => skip
      Hide
      Eric Hartmann added a comment -

      Ok tested every parameter given at command line overriddes the value on the profile.
      So everything works perfectly for me.

      Show
      Eric Hartmann added a comment - Ok tested every parameter given at command line overriddes the value on the profile. So everything works perfectly for me.

        People

        • Assignee:
          Evgeny Mandrikov
          Reporter:
          Evgeny Mandrikov
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: