SonarQube Plugins

CxxLineCounter leaks file descriptors

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: CXX-0.1
  • Component/s: Cxx
  • Labels:
    None
  • Environment:
    RedHat Linux 2.4.21
  • Number of attachments :
    1

Description

CxxLineCounter loops on file using file readers, but doesn't close them once done. On very large projects (several thousands of files and millions of lines of codes) we quickly run out of descriptors and the line counter fails without failing the sonar build, giving a erroneous report
Patch provided in attachment with some additional logging

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Waleri Enns added a comment -

Thanks for the patch.

Should be fixed with revision 5282. Can you please test and close the issue of the bug is gone?

Show
Waleri Enns added a comment - Thanks for the patch. Should be fixed with revision 5282. Can you please test and close the issue of the bug is gone?
Waleri Enns made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Assignee Waleri Enns [ wenns ]
Fix Version/s CXX-0.1 [ 18353 ]
Resolution Fixed [ 1 ]
Hide
Permalink
JP Chemali added a comment -

Hi Waleri, thanks for the quick update and sorry for the slow feedback.
I confirm it's fixed with revision 5303. For information purposes, we are now able to process 10 million LoC and 40000 files (source import and duplications only, no RATS,etc,... in this)

Show
JP Chemali added a comment - Hi Waleri, thanks for the quick update and sorry for the slow feedback. I confirm it's fixed with revision 5303. For information purposes, we are now able to process 10 million LoC and 40000 files (source import and duplications only, no RATS,etc,... in this)
Hide
Permalink
Waleri Enns added a comment -

Reporter confirmed that the issue is solved for him, too

Show
Waleri Enns added a comment - Reporter confirmed that the issue is solved for him, too
Waleri Enns made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Waleri Enns
    Reporter:
    JP Chemali
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: