Sonar Plugins

Check of JAVA_HOME in sonnar-runner.bat

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: SONAR-RUNNER-1.3
  • Component/s: Sonar Runner
  • Labels:
    None
  • Number of attachments :
    0

Description

If JAVA_HOME is not defined, the output does not really help the user :

C:\Projects\symfony>c:\sonar-runner-1.2\bin\sonar-runner
c:\sonar-runner-1.2\bin\..
The system cannot find the path specified.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Freddy Mallet added a comment -

Works well Fabrice nevertheless I'd have allowed the user to not have to specify the JAVA_HOME env variable if the java command was in the path. Indeed otherwise it requires another configuration step for the "basic" user. Looks like the title of this ticket was a bit misleading because when the JAVA_HOME env variable is wrongly defined we have the same issue. So at the end, looks like the expectation was :

  • When the JAVA_HOME env variable is defined, use it to determine the path to the java command
  • When the java command doesn't exist in the path and when the JAVA_HOME env variable is not defined, log a meaningful message
  • When the JAVA_HOME env variable is defined but the java command can't be found from this location, log a meaningful message.

Eric, what's your feeling about that ?
Thanks

Show
Freddy Mallet added a comment - Works well Fabrice nevertheless I'd have allowed the user to not have to specify the JAVA_HOME env variable if the java command was in the path. Indeed otherwise it requires another configuration step for the "basic" user. Looks like the title of this ticket was a bit misleading because when the JAVA_HOME env variable is wrongly defined we have the same issue. So at the end, looks like the expectation was : When the JAVA_HOME env variable is defined, use it to determine the path to the java command When the java command doesn't exist in the path and when the JAVA_HOME env variable is not defined, log a meaningful message When the JAVA_HOME env variable is defined but the java command can't be found from this location, log a meaningful message. Eric, what's your feeling about that ? Thanks
Hide
Permalink
Fabrice Bellingard added a comment -

The script should meet your requirements now, Freddy.

Show
Fabrice Bellingard added a comment - The script should meet your requirements now, Freddy.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !
Hide
Permalink
Fabrice Bellingard added a comment -

No need for IT.

Show
Fabrice Bellingard added a comment - No need for IT.

People

  • Assignee:
    Fabrice Bellingard
    Reporter:
    Eric Hartmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: