SonarQube Plugins
  1. SonarQube Plugins
  2. SONARPLUGINS-1561

Improve loading of changelog on big projects

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SCM-ACTIVITY-1.3
    • Fix Version/s: SCM-ACTIVITY-1.4
    • Component/s: SCM Activity
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      See this discussion.

      Note that a patch is attached.

      1. optimize_changeset.patch
        4 kB
        Simon Brandhof
      2. project_status.diff
        4 kB
        Evgeny Mandrikov

        Activity

        Hide
        Simon Brandhof added a comment -

        Note that the attached patch does not work because filenames must not normalized when comparing FileStatus and ChangeSet (see http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.scm/maven-scm-api/1.4/org/apache/maven/scm/ChangeSet.java#214)

        Show
        Simon Brandhof added a comment - Note that the attached patch does not work because filenames must not normalized when comparing FileStatus and ChangeSet (see http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.scm/maven-scm-api/1.4/org/apache/maven/scm/ChangeSet.java#214 )
        Hide
        Evgeny Mandrikov added a comment -

        Attached second patch from discussion.

        Show
        Evgeny Mandrikov added a comment - Attached second patch from discussion.
        Hide
        Vladimir Kralik added a comment -

        I'm going to try fix this issue, because I've really big mercurial repository ( 55 thousand changesets, 1 milion lines of java code ).

        Show
        Vladimir Kralik added a comment - I'm going to try fix this issue, because I've really big mercurial repository ( 55 thousand changesets, 1 milion lines of java code ).
        Hide
        Vladimir Kralik added a comment -

        I've created requirement to maven-scm-plugin to create callback-method for changelog. SCM-675

        Show
        Vladimir Kralik added a comment - I've created requirement to maven-scm-plugin to create callback-method for changelog. SCM-675
        Hide
        Vladimir Kralik added a comment -

        I've created one simple patch which uses HashMap for FileStatus instead of list.

        https://github.com/vlk32/sonar-scm-activity/commit/b3ebe4e0a95499cae9928ad58d3992d0f93b97d4

        Also I've created new issue SONARPLUGINS-1870, for the next optimisation of initialisation run.

        Show
        Vladimir Kralik added a comment - I've created one simple patch which uses HashMap for FileStatus instead of list. https://github.com/vlk32/sonar-scm-activity/commit/b3ebe4e0a95499cae9928ad58d3992d0f93b97d4 Also I've created new issue SONARPLUGINS-1870 , for the next optimisation of initialisation run.
        Hide
        David Gageot added a comment -

        With version 1.4, we don't load changesets anymore

        Show
        David Gageot added a comment - With version 1.4, we don't load changesets anymore
        Hide
        Freddy Mallet added a comment -

        Manually tested !

        Show
        Freddy Mallet added a comment - Manually tested !

          People

          • Assignee:
            Simon Brandhof
            Reporter:
            Simon Brandhof
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: