Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: FLEX-0.4
    • Fix Version/s: FLEX-1.1
    • Component/s: Flex
    • Labels:
      None
    • Number of attachments :
      0

      Description

      It appears that there is a problem with the LOC counter for the flex plug-in. I'll use the real life example from the flex plug-in page on the sonar website – http://nemo.sonarsource.org/dashboard/index/com.adobe:as3corelib

      LOC – http://nemo.sonarsource.org/drilldown/measures/com.adobe:as3corelib?metric=ncloc
      Physical lines – http://nemo.sonarsource.org/drilldown/measures/com.adobe:as3corelib?metric=lines

      com.adobe.net.URI has roughly 2450 physical lines, but only 1 LOC according to Sonar.

      Not all files are showing this problem, however.

        Issue Links

          Activity

          Hide
          Fabrice Bellingard added a comment -

          Good catch, Josh!

          I've made some tests, and the problem comes from FlexMetrics which fails to parse some files (like URI.as). The problem is that it fails silently, while printing out a report for the file in the "javancss-raw-report.xml" file (in which it sets every metric to '0', which is misleading for the Sonar Flex plugin...).

          The bad news is that from what I can see on FlexMetrics (and more generally FlexPMD) website, those projects seem to be inactive and I'm afraid we won't get a fix for this

          Show
          Fabrice Bellingard added a comment - Good catch, Josh! I've made some tests, and the problem comes from FlexMetrics which fails to parse some files (like URI.as). The problem is that it fails silently, while printing out a report for the file in the "javancss-raw-report.xml" file (in which it sets every metric to '0', which is misleading for the Sonar Flex plugin...). The bad news is that from what I can see on FlexMetrics (and more generally FlexPMD) website, those projects seem to be inactive and I'm afraid we won't get a fix for this
          Hide
          Evgeny Mandrikov added a comment -

          This bug is vanished because we don't use FlexMetrics anymore - SONARPLUGINS-1906.

          I've tested this concrete example and for URI.as we now report around 1000 lines of code.

          Show
          Evgeny Mandrikov added a comment - This bug is vanished because we don't use FlexMetrics anymore - SONARPLUGINS-1906 . I've tested this concrete example and for URI.as we now report around 1000 lines of code.
          Hide
          Fabrice Bellingard added a comment -

          Manually tested

          Show
          Fabrice Bellingard added a comment - Manually tested
          Hide
          Evgeny Mandrikov added a comment -

          Integration test updated.

          Show
          Evgeny Mandrikov added a comment - Integration test updated.

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Josh Figler
            • Votes:
              7 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: