Sonar Plugins

Allow blank password for scm user

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: SCM-ACTIVITY-1.3
  • Fix Version/s: SCM-ACTIVITY-1.4
  • Component/s: SCM Activity
  • Labels:
    None
  • Environment:
    Subversion
  • Number of attachments :
    0

Description

For whatever reason, we don't allow anonymous access, but have a readonly user who has a blank password. It seems we cannot configure this user because the code in SonarScmRepository.java checks for either blank user or blank password, then use anonymous. I think it probably should be if the user is blank, use anonymous, not either.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Gageot added a comment -

Done

Show
David Gageot added a comment - Done
Hide
Permalink
David Gageot added a comment -

We now skip setting the credentials only if both the login and password are blank.

Show
David Gageot added a comment - We now skip setting the credentials only if both the login and password are blank.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

David could you just update the following property description :

Activation of this SCM Activity plugin
sonar.scm.enabled
This property must be set to true in order to activate the SCM Activity plugin.

sonar.scm.password.secured
Optional password to be used to retrieve blame information from the SCM engine.

sonar.scm.user.secured
Optional user to be used to retrieve blame information from the SCM engine.

sonar.scm.url
SCM URL. The format is described in this page. Example:scm:svn:https://svn.codehaus.org/sonar-plugins/trunk/scm-activity. This property is mainly used to determine the SCM engine client to be used.

Show
Freddy Mallet added a comment - Manually tested ! David could you just update the following property description : Activation of this SCM Activity plugin sonar.scm.enabled This property must be set to true in order to activate the SCM Activity plugin. sonar.scm.password.secured Optional password to be used to retrieve blame information from the SCM engine. sonar.scm.user.secured Optional user to be used to retrieve blame information from the SCM engine. sonar.scm.url SCM URL. The format is described in this page. Example:scm:svn: https://svn.codehaus.org/sonar-plugins/trunk/scm-activity . This property is mainly used to determine the SCM engine client to be used.
Hide
Permalink
David Gageot added a comment -

Done

Show
David Gageot added a comment - Done
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !

People

  • Assignee:
    Simon Brandhof
    Reporter:
    Andrew Ochsner
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: