SonarQube Plugins

Import of Violations is too slow for large projects

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: PHP-0.4
  • Fix Version/s: PHP-0.5
  • Component/s: PHP
  • Labels:
    None
  • Environment:
    Large PHP Projects > 1000 of files with lots of violations
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

For a large PHP projects with lots of it takes too long to import Codesniffer/PHPMD violations. (I have a Project where it takes about 7 hours)

The reason is that for every violation the whole Source-Directories tree is scanned.

In earlier versions (0.2-0.3) there was no such problem.

The attached patch solves this problem.

  1. Text File
    PhpFile.patch
    26/Apr/11 2:03 AM
    2 kB
    Gennadiy Litvinyuk

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SONARPLUGINS-974 Settings for exclude directorys and files not honored

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gennadiy Litvinyuk added a comment -

The attached patch has reduced the import time from about 7 hours to 7 minutes in one project.

Show
Gennadiy Litvinyuk added a comment - The attached patch has reduced the import time from about 7 hours to 7 minutes in one project.
Hide
Permalink
Akram Ben Aissi added a comment -

Hi Gennadiy
thank you for the submitting the patch. It could not be added as is, because of a previous issue, that is linked to this.
However, another fix is pending, to avoid looking on filesystem everytime we want to check if files is present in project.

Show
Akram Ben Aissi added a comment - Hi Gennadiy thank you for the submitting the patch. It could not be added as is, because of a previous issue, that is linked to this. However, another fix is pending, to avoid looking on filesystem everytime we want to check if files is present in project.
Hide
Permalink
Akram Ben Aissi added a comment -

Source files list and test files list are now cached.

Show
Akram Ben Aissi added a comment - Source files list and test files list are now cached.
Hide
Permalink
Fabrice Bellingard added a comment -

Tested, looks fine.

Show
Fabrice Bellingard added a comment - Tested, looks fine.

People

  • Assignee:
    Akram Ben Aissi
    Reporter:
    Gennadiy Litvinyuk
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: