Sonar Plugins

Ability to view source for MXML files

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: FLEX-0.3.1
  • Fix Version/s: FLEX-1.0
  • Component/s: Flex
  • Labels:
    None
  • Environment:
    Windows OS
  • Patch Submitted:
    Yes
  • Number of attachments :
    3

Description

When analyzing a flex project, we are able to see correctly the mxml files that are stored at root level, but not files that are stored in a directory.
I added the analysis for mxml as well as for as (by the way it may be good to analyze by default those two extensions to avoid getting questions about that).
I attached a simple project where the file FlexSonarSourceMXML at root level is correctly displayed after the analysis but the file FlexSonarSourceMXML1 located in directory pk1

I also attached a screenshot of sonar analysis where it appears that sonar is considering the second file differently.

Activity

Ascending order - Click to sort in descending order
Evgeny Mandrikov made changes -
Field Original Value New Value
Assignee Evgeny Mandrikov [ godin ]
Hide
Permalink
Evgeny Mandrikov added a comment -

Hi Stephane,

First of all - I wonder why your code doesn't contain "package" declarations ( http://livedocs.adobe.com/flex/3/html/help.html?content=basic_as_2.html ) ?
Second - do you know about property "sonar.flex.file.suffixes" (Settings -> Flex -> File suffixes) ?

Show
Evgeny Mandrikov added a comment - Hi Stephane, First of all - I wonder why your code doesn't contain "package" declarations ( http://livedocs.adobe.com/flex/3/html/help.html?content=basic_as_2.html ) ? Second - do you know about property "sonar.flex.file.suffixes" (Settings -> Flex -> File suffixes) ?
Evgeny Mandrikov made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
stephane Renou added a comment -

Concerning first, our issue is not for the as files as those are correctly processed by the system (here we wanted to build a quick project and may have forgotten about that) but our concern is on the analysis of the mxml files.
Yes we have defined the sonar.flex.file.suffixes with as and mxml and that was also my second comment, that maybe by default you should get both as and mxml files to be analyzed.

So with a setup that seems correct (at least it allows us to see the mxml file stored at root level) we are not able to see a file stored onder a subfolder. Both are correctly analysed as we get issues reported on that other file, it is more issues with the display mechanism.

Show
stephane Renou added a comment - Concerning first, our issue is not for the as files as those are correctly processed by the system (here we wanted to build a quick project and may have forgotten about that) but our concern is on the analysis of the mxml files. Yes we have defined the sonar.flex.file.suffixes with as and mxml and that was also my second comment, that maybe by default you should get both as and mxml files to be analyzed. So with a setup that seems correct (at least it allows us to see the mxml file stored at root level) we are not able to see a file stored onder a subfolder. Both are correctly analysed as we get issues reported on that other file, it is more issues with the display mechanism.
Evgeny Mandrikov made changes -
Status In Progress [ 3 ] Open [ 1 ]
Evgeny Mandrikov made changes -
Assignee Evgeny Mandrikov [ godin ]
Hide
Permalink
Jorge Castello added a comment -

Same for us here. We have a Flex module wich contains the following structure:

(1) /FiscalizacionModule.mxml
(2) /es/foo/bar/view/StringDateFieldChangeEvent.as
(3) /es/foo/bar/view/StringTextInputFieldChangeEvent.as
(4) /es/foo/bar/view/FechaPieReport.mxml
(5) /es/foo/bar/model/ModelLocatorFiscalizacionPrevia.as
(6) /es/foo/bar/model/Nomina.mxml

We can only see sources (violations, coverage and so) on files 1,2,3 & 5, but not for 4 & 6

Sonar 2.5, Sonar Flex Plugin 0.3.1

Show
Jorge Castello added a comment - Same for us here. We have a Flex module wich contains the following structure: (1) /FiscalizacionModule.mxml (2) /es/foo/bar/view/StringDateFieldChangeEvent.as (3) /es/foo/bar/view/StringTextInputFieldChangeEvent.as (4) /es/foo/bar/view/FechaPieReport.mxml (5) /es/foo/bar/model/ModelLocatorFiscalizacionPrevia.as (6) /es/foo/bar/model/Nomina.mxml We can only see sources (violations, coverage and so) on files 1,2,3 & 5, but not for 4 & 6 Sonar 2.5, Sonar Flex Plugin 0.3.1
Hide
Permalink
Eugene Zadyra added a comment - - edited

Patch to fix this issue attached

Show
Eugene Zadyra added a comment - - edited Patch to fix this issue attached
Evgeny Mandrikov made changes -
Patch Submitted Yes [ 10070 ]
Hide
Permalink
stephane Renou added a comment -

hello, is there any plan on integrating this patch into an official release?

Show
stephane Renou added a comment - hello, is there any plan on integrating this patch into an official release?
Evgeny Mandrikov made changes -
Assignee Evgeny Mandrikov [ godin ]
Fix Version/s FLEX-0.5 [ 18265 ]
Hide
Permalink
Evgeny Mandrikov added a comment -

Hi Eugene,
In this patch I didn't found any unit test to verify new behaviour.
May I ask you to provide new one with included unit tests?

Show
Evgeny Mandrikov added a comment - Hi Eugene, In this patch I didn't found any unit test to verify new behaviour. May I ask you to provide new one with included unit tests?
Evgeny Mandrikov made changes -
Assignee Evgeny Mandrikov [ godin ]
Hide
Permalink
Fabrice Bellingard added a comment -

SONARPLUGINS-1666 solves this issue.

Show
Fabrice Bellingard added a comment - SONARPLUGINS-1666 solves this issue.
Fabrice Bellingard made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Fabrice Bellingard [ fabemn ]
Resolution Fixed [ 1 ]
Freddy Mallet made changes -
Assignee Fabrice Bellingard [ fabemn ] Freddy Mallet [ freddy.mallet ]
Hide
Permalink
Freddy Mallet added a comment -

Manually tested

Show
Freddy Mallet added a comment - Manually tested
Freddy Mallet made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Assignee Freddy Mallet [ freddy.mallet ] Fabrice Bellingard [ fabemn ]

People

  • Assignee:
    Fabrice Bellingard
    Reporter:
    stephane Renou
Vote (3)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: