Sonar Plugins

Change sonar.php.cpd.skip option into sonar.phpcpd.skip

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: PHP-0.3
  • Fix Version/s: PHP-0.5
  • Component/s: PHP
  • Labels:
    None
  • Number of attachments :
    0

Description

The option sonar.phpcpd.shouldRun allows user to disable phpcpd execution.
Moreover, there is another useless option named sonar.php.cpd.skip that does the same job.

A standard sonar option named sonar.cpd.skip already exists, and it should nice if phpcpd is disabled if this option is also set.

The rule could be:
if one of the options says disable it, phpcpd must be disabled.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sebastian Marek added a comment -

As discussed Akram, I have kept both sonar.php.cpd.skip and sonar.phpcpd.shouldRun as deprecated options (see SONARPLUGINS-975), and introduced sonar.cpd.skip option.

From 0.5 release though I will remove both of them and make it more "sonar compatible" with sonar.cpd.skip and sonar.cpd.php.skip options available, the latter taking the precedence.

Show
Sebastian Marek added a comment - As discussed Akram, I have kept both sonar.php.cpd.skip and sonar.phpcpd.shouldRun as deprecated options (see SONARPLUGINS-975 ), and introduced sonar.cpd.skip option. From 0.5 release though I will remove both of them and make it more "sonar compatible" with sonar.cpd.skip and sonar.cpd.php.skip options available, the latter taking the precedence.
Hide
Permalink
Fabrice Bellingard added a comment -

I changed "sonar.php.cpd.skip" option into "sonar.phpcpd.skip" to be consistent in parameter naming.

I removed "sonar.cpd.skip" as I don't think we should align on this property, which was introduced for Java CPD at the beginning. IMO, each tools should have their own parameters.

"sonar.phpcpd.shouldRun" is still available, and will be removed in a couple of next versions.

Show
Fabrice Bellingard added a comment - I changed "sonar.php.cpd.skip" option into "sonar.phpcpd.skip" to be consistent in parameter naming. I removed "sonar.cpd.skip" as I don't think we should align on this property, which was introduced for Java CPD at the beginning. IMO, each tools should have their own parameters. "sonar.phpcpd.shouldRun" is still available, and will be removed in a couple of next versions.

People

  • Assignee:
    Fabrice Bellingard
    Reporter:
    Akram Ben Aissi
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: