SonarQube Plugins
  1. SonarQube Plugins
  2. SONARPLUGINS-1022

Deactivated rules of fbcontrib can cause OutOfMemoryError

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: FB-CONTRIB-1.0
    • Fix Version/s: FB-CONTRIB-1.1
    • Component/s: fb-contrib
    • Labels:
      None
    • Environment:
      Ubuntu 10.04.1LTS and Sun JDK 1.6.0_24
      export MAVEN_OPTS="-XX:MaxPermSize=192m -XX:PermSize=192m -Xms1024m -Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -Xss256k"
    • Number of attachments :
      2

      Description

      Originally I wanted to create an issue about OutOfMemoryError, but this is fbcontrib's problem and issue is here:
      https://sourceforge.net/tracker/?func=detail&aid=3204521&group_id=147536&atid=768725

      Originally I wanted to uninstall the plugin, but then I decided to only uncheck the problematic rule - and then I have seen that all the fb-contrib rules are already disabled ... but analysis has been done!

      A few days before I upgraded the Sonar from 2.4.1 to 2.5 and then to 2.6.
      Then I installed the fbcontrib plugin and successfully analyzed some projects - fbcontrib results are missing despite the analysis has been done.

      So, simply:
      Correct: deactivated rules should be skipped already when analyzing the classes
      Now I: Classes are analyzed, but results of the deactivated rules are ignored.
      Now II: Deactivated rule can crash the build
      Now III: Deactivated rules slow down the maven build.

      Now I uninstalled the fbcontrib sonar plugin.

      Attachements:
      1) Stacktrace in a part of the maven output
      2) JConsole snapshot - about 20 minutes before the crash is analysed the only one subproject. About 40 minutes before took the analysis of another 20 subprojects of similar size and complexity. This is why I think that it is a blocker issue - it is fatal.

      1. fbcontrib-stacktrace.log
        9 kB
        David Matejcek
      1. fbcontrib-jconsole.png
        123 kB

        Issue Links

          Activity

          Hide
          Evgeny Mandrikov added a comment -

          Hi David,
          Do you still affected by this issue?

          Show
          Evgeny Mandrikov added a comment - Hi David, Do you still affected by this issue?
          Hide
          David Matejcek added a comment -

          Sorry for my late response. I will upgrade to the current Sonar and plugin version and try it again, perhaps the next week - now I'm little bit under pressure ...

          Show
          David Matejcek added a comment - Sorry for my late response. I will upgrade to the current Sonar and plugin version and try it again, perhaps the next week - now I'm little bit under pressure ...
          Hide
          David Matejcek added a comment -

          Still the same on 2.7.
          Yet moving to Sonar 2.8.

          Show
          David Matejcek added a comment - Still the same on 2.7. Yet moving to Sonar 2.8.
          Hide
          David Matejcek added a comment -

          ... and it is still the same.

          Show
          David Matejcek added a comment - ... and it is still the same.
          Hide
          Evgeny Mandrikov added a comment - - edited

          Hi David,
          I'm closing this ticket according to following discussion : http://markmail.org/message/3gbweqxscajh3hft
          So could you please test snapshot version of plugin to see if OutOfMemoryError dissappeared?

          Show
          Evgeny Mandrikov added a comment - - edited Hi David, I'm closing this ticket according to following discussion : http://markmail.org/message/3gbweqxscajh3hft So could you please test snapshot version of plugin to see if OutOfMemoryError dissappeared?
          Hide
          David Matejcek added a comment -

          I don't know where I can get the snapshot version so I created my own from your repo.
          Great work, build took only three minutes on this module, no OOME with disabled rules, with enabled rules, even with FCBL_FIELD_COULD_BE_LOCAL (I hope this rule is the right).

          Show
          David Matejcek added a comment - I don't know where I can get the snapshot version so I created my own from your repo. Great work, build took only three minutes on this module, no OOME with disabled rules, with enabled rules, even with FCBL_FIELD_COULD_BE_LOCAL (I hope this rule is the right).

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              David Matejcek
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: