SonarQube Plugins
  1. SonarQube Plugins
  2. SONARPLUGINS-1010

Provide an option to set location of company logo in Sonar UI

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: BRANDING-0.1
    • Fix Version/s: BRANDING-0.2
    • Component/s: Branding
    • Labels:
      None
    • Number of attachments :
      1

      Description

      For my company I had already developped a very similar plugin. The differences are:

      • the image is a static resource (not possible here because it would mean people would have to compile the plugin with their own image).
      • the location of the logo was not the same: we chose to add it in the menu section, just under the Sonar logo

      Here is a patch that add an option to the plugin in order to specify the location. Currently supported locations are:

      • TOP (current behavior)
      • MENU (in the menu section)

        Activity

        Hide
        Evgeny Mandrikov added a comment -

        Hi Julien, problem with menu section - there is not so much space for badges like Apache or Codehaus. Moreover top location seems more standardized way - see Jira, Nexus, Jenkins, ...

        Show
        Evgeny Mandrikov added a comment - Hi Julien, problem with menu section - there is not so much space for badges like Apache or Codehaus. Moreover top location seems more standardized way - see Jira, Nexus, Jenkins, ...
        Hide
        Julien HENRY added a comment -

        Hi Evgeny,

        Of course the user should decide what location is the best according to the size of the logo. In my case the logo is a square so it is much better in the menu section than in the top location. Also I want to save space for filters and dashboards so this is another reason to not put the logo on top.

        Thanks

        Show
        Julien HENRY added a comment - Hi Evgeny, Of course the user should decide what location is the best according to the size of the logo. In my case the logo is a square so it is much better in the menu section than in the top location. Also I want to save space for filters and dashboards so this is another reason to not put the logo on top. Thanks
        Hide
        Julien HENRY added a comment -

        Hi Evgeny,

        Any update for this patch? I am currently using a patched version of the branding plugin but I don't want it to stay as a long-term solution. I feel you were not in favor of this patch, but I don't know if my previous answer was convincing or not.

        Regards

        Show
        Julien HENRY added a comment - Hi Evgeny, Any update for this patch? I am currently using a patched version of the branding plugin but I don't want it to stay as a long-term solution. I feel you were not in favor of this patch, but I don't know if my previous answer was convincing or not. Regards
        Hide
        Julien HENRY added a comment -

        Now that I am a commiter, do you mind if I apply this patch?

        Show
        Julien HENRY added a comment - Now that I am a commiter, do you mind if I apply this patch?
        Hide
        Freddy Mallet added a comment -

        Let's go to apply the patch and launch a vote Julien.

        Show
        Freddy Mallet added a comment - Let's go to apply the patch and launch a vote Julien.
        Hide
        Julien HENRY added a comment -

        Fixed in r4363

        Show
        Julien HENRY added a comment - Fixed in r4363

          People

          • Assignee:
            Julien HENRY
            Reporter:
            Julien HENRY
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: