Email send fails if username/password are blank

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EMAIL-0.1
Fix Version/s: EMAIL-0.2
Component/s: Email
Labels:
None
Environment:
linux (centos 5.5) trying to send through exchange

Patch Submitted:

Yes
Number of attachments :
1

Description

Relatively easy fix, if both the username & password are empty, don't try using them at all. Per the docs for SimpleEmail, authentication won't be used if .setAuthentication isn't called (http://commons.apache.org/email/apidocs/org/apache/commons/mail/Email.html#setAuthentication%28java.lang.String,%20java.lang.String%29)

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

fix.txt

22/Feb/11 9:22 PM

0.7 kB

Matthew Hildebrand

Activity

Ascending order - Click to sort in descending order

Matthew Hildebrand made changes - 22/Feb/11 9:22 PM

Field	Original Value	New Value
Attachment		fix.txt [ 53889 ]

Evgeny Mandrikov made changes - 23/Feb/11 3:47 AM

Description

If username/password is left empty, the app still tries to use them to authenticate against the mail server. Some mailservers are configured to accept anonymous sends from certain IP ranges and won't accept authentication from that range (read: I don't have a user that I'm willing to put credentials visible for, and my build server is allowed to anonymously send messages through our exchange server).

Relatively easy fix, if both the username & password are empty, don't try using them at all. Per the docs for SimpleEmail, authentication won't be used if .setAuthentication isn't called (http://commons.apache.org/email/apidocs/org/apache/commons/mail/Email.html#setAuthentication%28java.lang.String,%20java.lang.String%29)

try {
      email.setHostName(host);
      email.setSmtpPort(port);
++ if((username != null && username.trim != "") || (password != null && password.trim != "") {
-- email.setAuthentication(username, password);
++ email.setAuthentication(username, password);
++ }
      email.setTLS(withTLS);
      email.setFrom(from);

      String[] addrs = StringUtils.split(to, '\n');
      for (String addr : addrs) {
        email.addTo(addr);
      }
      email.setSubject(getSubject(project));
      email.setMsg(getMessage(project));
      email.send();
    } catch (EmailException e) {
      throw new SonarException("Unable to send email", e);
    }

Evgeny Mandrikov made changes - 23/Feb/11 6:50 PM

Fix Version/s

EMAIL-0.2 [ 17195 ]

Evgeny Mandrikov made changes - 23/Feb/11 8:10 PM