SonarQube JavaScript
  1. SonarQube JavaScript
  2. SONARJS-190

The Javascript analyser doesn't support the HTML comment embedded into the javascript source code

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      In the following case a lexing issue is raised whereas this should not be the case :

      13:48:50  ---------------
      13:48:50    168 }
      13:48:50    169 function closePopupOver()
      13:48:50    170   {
      13:48:50    171    $('#mask').hide();
      13:48:50    172    $('.window').hide();
      13:48:50    173    showDropdowns();
      13:48:50    174   }
      13:48:50    175
      13:48:50    --> <!-- This is a comment -->
      13:48:50    177 function selectRadioButton()
      13:48:50    178 {
      13:48:50    179 document.getElementById('ModalPopupDivQuote').innerHTML=""
      

        Issue Links

          Activity

          Hide
          Evgeny Mandrikov added a comment -

          Freddy, where this code was obtained? The thing is that according to ECMAScript standard there is only two types of comments : "//" and "/* .. */".

          Show
          Evgeny Mandrikov added a comment - Freddy, where this code was obtained? The thing is that according to ECMAScript standard there is only two types of comments : "//" and "/* .. */".
          Hide
          Freddy Mallet added a comment -

          Based on customer feedback which didn't manage anymore to analyse its javascript source files with version 1.0 of the Javascript plugin. See http://www.javascripter.net/faq/comments.htm.

          Show
          Freddy Mallet added a comment - Based on customer feedback which didn't manage anymore to analyse its javascript source files with version 1.0 of the Javascript plugin. See http://www.javascripter.net/faq/comments.htm .
          Hide
          Freddy Mallet added a comment -

          Works well Evgeny, could you just also update the javascript source code colorizer ?

          Show
          Freddy Mallet added a comment - Works well Evgeny, could you just also update the javascript source code colorizer ?
          Hide
          Evgeny Mandrikov added a comment -

          Done.

          Show
          Evgeny Mandrikov added a comment - Done.
          Hide
          Freddy Mallet added a comment - - edited

          Manually tested !

          The colorization of HTML comment is not done in the toolkit but that's not an issue.

          Show
          Freddy Mallet added a comment - - edited Manually tested ! The colorization of HTML comment is not done in the toolkit but that's not an issue.

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Freddy Mallet
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: