Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Issue Links

        Activity

        Hide
        Dinesh Bolkensteyn added a comment -

        Looks good to me (didn't test it though), well done for the re-use of the generic check

        However I believe it would be better to go for internationalization right away, and provide an example, as we do on the other plugin (and thereby really making it a first class plugin ).

        Show
        Dinesh Bolkensteyn added a comment - Looks good to me (didn't test it though), well done for the re-use of the generic check However I believe it would be better to go for internationalization right away, and provide an example, as we do on the other plugin (and thereby really making it a first class plugin ).
        Hide
        Evgeny Mandrikov added a comment -

        Indeed Dinesh - I agree that we should improve names and descriptions. This wasn't done, because of lack of time

        About internationalization - this might mean upgrade of minimal required version of Sonar, so with Freddy we decided to postpone this, however I'll give it a try before release.

        Show
        Evgeny Mandrikov added a comment - Indeed Dinesh - I agree that we should improve names and descriptions. This wasn't done, because of lack of time About internationalization - this might mean upgrade of minimal required version of Sonar, so with Freddy we decided to postpone this, however I'll give it a try before release.
        Hide
        Freddy Mallet added a comment - - edited

        Manually tested, could you just update the description with the following lines :

        <p>
        The following code snippet illustrates this rule :
        </p>
        
        <pre>
            this.firstParam = "something";this.secondParam = "somethingElse";     //NOK as there are two statements
        </pre>
        
        Show
        Freddy Mallet added a comment - - edited Manually tested, could you just update the description with the following lines : <p> The following code snippet illustrates this rule : </p> <pre> this.firstParam = "something";this.secondParam = "somethingElse"; //NOK as there are two statements </pre>
        Hide
        Evgeny Mandrikov added a comment -

        Done.

        Show
        Evgeny Mandrikov added a comment - Done.
        Hide
        Freddy Mallet added a comment -

        Manually tested !

        Show
        Freddy Mallet added a comment - Manually tested !

          People

          • Assignee:
            Evgeny Mandrikov
            Reporter:
            Evgeny Mandrikov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: