Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      See "shadow" in http://www.jshint.com/docs/

        Issue Links

          Activity

          Hide
          Evgeny Mandrikov added a comment -

          Integration tests were updated.

          Show
          Evgeny Mandrikov added a comment - Integration tests were updated.
          Hide
          Freddy Mallet added a comment -

          Works well Evgeny!

          Here is the description :

          Overriding a variable declared in an outer scope might highly impact the readability and so maintainability of a piece of code.

          The following code snippet illustrates this rule:

            show: function(point, element) {
              if(!this.drops.length) return;
              var drop, affected = [];
          
              this.drops.each( function(drop) { //Non-Compliant as the 'drop' parameter is not the one defined one line before even if it looks like
                if(Droppables.isAffected(point, element, drop))
                  affected.push(drop);
              });
            ...
          
          Show
          Freddy Mallet added a comment - Works well Evgeny! Here is the description : Overriding a variable declared in an outer scope might highly impact the readability and so maintainability of a piece of code. The following code snippet illustrates this rule: show: function(point, element) { if (! this .drops.length) return ; var drop, affected = []; this .drops.each( function(drop) { //Non-Compliant as the 'drop' parameter is not the one defined one line before even if it looks like if (Droppables.isAffected(point, element, drop)) affected.push(drop); }); ...
          Hide
          Evgeny Mandrikov added a comment -

          Done.

          Show
          Evgeny Mandrikov added a comment - Done.
          Hide
          Freddy Mallet added a comment -

          Manually tested !

          Show
          Freddy Mallet added a comment - Manually tested !

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Evgeny Mandrikov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: