SonarQube Jenkins
  1. SonarQube Jenkins
  2. SONARJNKNS-147

Property sonar.branch should be taken from pom.xml for link to dashboard

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1
    • Labels:
      None
    • Number of attachments :
      0

      Description

        Issue Links

          Activity

          Hide
          Chris van Es added a comment - - edited

          Any update on this? What the process for submitting patches? Are pull requests from github accepted if I can have a look at this?

          I was thinking that if the Jenkins UI sonar.branch property was not defined then use the maven help plugin (mvn help:evaluate -Dexpression=sonar.branch) to get the value of the property from the POM otherwise revert to current behaviour. Sound reasonable?

          Show
          Chris van Es added a comment - - edited Any update on this? What the process for submitting patches? Are pull requests from github accepted if I can have a look at this? I was thinking that if the Jenkins UI sonar.branch property was not defined then use the maven help plugin (mvn help:evaluate -Dexpression=sonar.branch) to get the value of the property from the POM otherwise revert to current behaviour. Sound reasonable?
          Hide
          Chris van Es added a comment -

          Either that or add config to allow using the POM version for the sonar.branch value.

          Show
          Chris van Es added a comment - Either that or add config to allow using the POM version for the sonar.branch value.
          Hide
          Julien HENRY added a comment -

          It seems there is no easy way to access resolved pom properties from a Jenkins plugin. Here maybe the best solution would be to patch Jenkins to expose pom properties.

          Show
          Julien HENRY added a comment - It seems there is no easy way to access resolved pom properties from a Jenkins plugin. Here maybe the best solution would be to patch Jenkins to expose pom properties.
          Hide
          Julien HENRY added a comment -

          As a first step we will consider sonar.branch from the "parsed" pom (but not "resolved"). It means that if the property is defined in parent pom or is composed of other properties then it will not works.

          Show
          Julien HENRY added a comment - As a first step we will consider sonar.branch from the "parsed" pom (but not "resolved"). It means that if the property is defined in parent pom or is composed of other properties then it will not works.
          Hide
          Julien HENRY added a comment -

          This issue should be closed and all efforts should go to SONARPLUGINS-2814

          Show
          Julien HENRY added a comment - This issue should be closed and all efforts should go to SONARPLUGINS-2814
          Hide
          Fabrice Bellingard added a comment -

          Tested!

          Show
          Fabrice Bellingard added a comment - Tested!

            People

            • Assignee:
              Julien HENRY
              Reporter:
              Evgeny Mandrikov
            • Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: