Only run Sonar on nightly build

Hi Ben,
That's a really interesting proposal, particularly the first implementation.
But your patch does not work if there are only periodical builds, for example only nightly builds. Sonar will not be executed if there are SCM updates.

The following code of SonarPublisher :

if (sonarInstallation.isSkipOnScm() && !build.getChangeSet().isEmptySet()) {

checks if there are SCM updates. In fact it should check if the build was triggered by an hudson.triggers.TimeTrigger but not by an hudson.triggers.SCMTrigger.

Do you know how can we do that ?

Yes, I agree...I would prefer to check on the trigger type. I am new to writing Hudson plugins, and the isEmptySet() was the first call I found that worked for us.

Our use case, obviously, is that we have SCM triggers during the day, and a @midnight trigger to run Sonar, so it works for us. And I would think that for this feature to be useful, you would have a similar use case – If you just has a periodic build anyway, than you don't need to worry about disabling Sonar on other builds.

Nonetheless, if anyone knows how to access the trigger type from with the plugin, please let me know or submit another patch.

Another change to this patch would be to make it a per-job configuration option instead of global.

I took a look at the code, and best that I can tell there is no way to tell which trigger caused the current build. Perhaps we could put a request into the general Hudson list to make this information available to this method, probably via a method call on build.

public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListener listener) 

From the AbstractBuild, you can get the Project, which gives you the configured Triggers for the project, but of course, this tells you both the TimerTrigger and the SCMTrigger.

See https://hudson.dev.java.net/issues/show_bug.cgi?id=2640

Good news, hudson issue is fixed.

Here is a new patch, that blocks sonar only when triggered by SCM explicitly (SCMTriggerCause).

I could also see changing this to say only trigger on TimerTriggerCause instead – either would work for us, but I think it makes more sense to blacklist SCM cause, instead of whitelist Timer, because I would think people do want Sonar to run when triggered by User or by Upstream.

issue resolved but skip scm configuration is done at the project config level and not sonar global config level