SonarQube Java
  1. SonarQube Java
  2. SONARJAVA-274

Depreciate PDM rules "Naming - Suspicious constant field name" and "Naming - Variable naming conventions"

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: Rules
    • Labels:
      None
    • Number of attachments :
      0

      Activity

      Hide
      Dinesh Bolkensteyn added a comment -

      I don't understand this ticket.

      Could you please explicitly say which (set of) rule deprecates which one?

      RSPEC-417 'Naming - Variable naming conventions' seems to already have been deprecated by another rule.

      The RSPEC-116 has not been updated with additional replaces links.

      Show
      Dinesh Bolkensteyn added a comment - I don't understand this ticket. Could you please explicitly say which (set of) rule deprecates which one? RSPEC-417 'Naming - Variable naming conventions' seems to already have been deprecated by another rule. The RSPEC-116 has not been updated with additional replaces links.
      Hide
      Freddy Mallet added a comment -

      PMD rule 'SuspiciousConstantFieldName' (cf http://jira.sonarsource.com/browse/RSPEC-414) is deprecated by Squid rule 'S00115' (cf http://jira.sonarsource.com/browse/RSPEC-115)

      PMD rule 'VariableNamingConventions' (cf http://jira.sonarsource.com/browse/RSPEC-417) is deprecated by Squid rule 'S00116' and 'S00115' (cf http://jira.sonarsource.com/browse/RSPEC-116 and http://jira.sonarsource.com/browse/RSPEC-115)

      Show
      Freddy Mallet added a comment - PMD rule 'SuspiciousConstantFieldName' (cf http://jira.sonarsource.com/browse/RSPEC-414 ) is deprecated by Squid rule 'S00115' (cf http://jira.sonarsource.com/browse/RSPEC-115 ) PMD rule 'VariableNamingConventions' (cf http://jira.sonarsource.com/browse/RSPEC-417 ) is deprecated by Squid rule 'S00116' and 'S00115' (cf http://jira.sonarsource.com/browse/RSPEC-116 and http://jira.sonarsource.com/browse/RSPEC-115 )
      Hide
      Dinesh Bolkensteyn added a comment -

      Done

      Show
      Dinesh Bolkensteyn added a comment - Done
      Hide
      Dinesh Bolkensteyn added a comment -

      I kind of doubt that the depreciations are the right ones.

      For example, SuspiciousConstantFieldName checks for local variables and/or method parameters which are in upper case, but which are not final.
      So it is more the local variable/method parameter names rule which should depreciate it.

      Show
      Dinesh Bolkensteyn added a comment - I kind of doubt that the depreciations are the right ones. For example, SuspiciousConstantFieldName checks for local variables and/or method parameters which are in upper case, but which are not final. So it is more the local variable/method parameter names rule which should depreciate it.
      Hide
      Freddy Mallet added a comment -

      You're right Dinesh :

      PMD rule 'SuspiciousConstantFieldName' (cf http://jira.sonarsource.com/browse/RSPEC-414) is deprecated by Squid rule 'S00116' (cf http://jira.sonarsource.com/browse/RSPEC-116)

      I've update RSPEC-414, I let you update the Java rule link. Thanks

      Show
      Freddy Mallet added a comment - You're right Dinesh : PMD rule 'SuspiciousConstantFieldName' (cf http://jira.sonarsource.com/browse/RSPEC-414 ) is deprecated by Squid rule 'S00116' (cf http://jira.sonarsource.com/browse/RSPEC-116 ) I've update RSPEC-414, I let you update the Java rule link. Thanks
      Hide
      Dinesh Bolkensteyn added a comment -

      And done!

      Show
      Dinesh Bolkensteyn added a comment - And done!
      Hide
      Freddy Mallet added a comment -

      Manually tested !

      Show
      Freddy Mallet added a comment - Manually tested !

        People

        • Assignee:
          Dinesh Bolkensteyn
          Reporter:
          Freddy Mallet
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: