SonarQube Java
  1. SonarQube Java
  2. SONARJAVA-147

Rule S00118: Abstract class names should comply with a naming convention

    Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      http://jira.sonarsource.com/browse/RSPEC-118

      Deprecate checkstyle:com.puppycrawl.tools.checkstyle.checks.naming.AbstractClassNameCheck and pmd:AbstractNaming

        Issue Links

          Activity

          Hide
          Fabrice Bellingard added a comment -

          This is weird, but this case is not covered:

          public class Bar {
            
            public abstract class Foo { // No violation triggered
          
            }
            
          }
          
          Show
          Fabrice Bellingard added a comment - This is weird, but this case is not covered: public class Bar { public abstract class Foo { // No violation triggered } }
          Hide
          Evgeny Mandrikov added a comment -

          Fixed.

          Show
          Evgeny Mandrikov added a comment - Fixed.
          Hide
          Fabrice Bellingard added a comment -

          Tested!

          Show
          Fabrice Bellingard added a comment - Tested!
          Hide
          Evgeny Mandrikov added a comment -

          Integration tests were updated.

          Show
          Evgeny Mandrikov added a comment - Integration tests were updated.
          Hide
          Fabrice Bellingard added a comment - - edited

          Feedback from David:

          • There's a typo in the description: "absctract" should be replaced by "abstract"
          • The description of the rule should clearly mention that if a class starts with the given pattern but is not abstract, this raises a violation.
          Show
          Fabrice Bellingard added a comment - - edited Feedback from David: There's a typo in the description: "absctract" should be replaced by "abstract" The description of the rule should clearly mention that if a class starts with the given pattern but is not abstract, this raises a violation.
          Hide
          Evgeny Mandrikov added a comment -

          Done.

          Show
          Evgeny Mandrikov added a comment - Done.
          Hide
          Fabrice Bellingard added a comment - - edited

          Checked.

          Show
          Fabrice Bellingard added a comment - - edited Checked.

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Evgeny Mandrikov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: