Pmd takes only one exclusion from Sonar

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.10
Component/s: Duplications
Labels:
None

Number of attachments :
1

Description

Sonar send to the PMD plugin only the first exclusion filter but Sonar filters all when updating the DB.
This leads to a difference between the plugins reports (via Hudson Violations or the Maven site) and Sonar.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

pmdExclusion.patch

20/May/09 3:27 AM

4 kB

Anthonin Bonnefoy

Issue Links

is related to

SONAR-853 Findbugs should generate exclude file for Maven

SONAR-854 Sonar should configure exclude sources for checkstyle plugin

Activity

Ascending order - Click to sort in descending order

Freddy Mallet made changes - 20/May/09 3:09 AM

Field	Original Value	New Value
Assignee		Freddy Mallet [ freddy.mallet ]

Hide

Permalink

Anthonin Bonnefoy added a comment - 20/May/09 3:11 AM

I'm going to submit a patch for this issue after some tests

Show

Anthonin Bonnefoy added a comment - 20/May/09 3:11 AM I'm going to submit a patch for this issue after some tests

Hide

Permalink

Freddy Mallet added a comment - 20/May/09 3:20 AM

You're right, the problem is located in the PmdMavenPluginHandler class :

  private void configureExclusions(MavenPlugin plugin) {
    if (exclusions!=null) {
      for (String pattern : exclusions.getWildcardPatterns()) {
        plugin.getConfiguration().setParameter("excludes/exclude", pattern);
      }
    }
  }

I guess we should call plugin.getConfiguration().addParameter(...) instead of plugin.getConfiguration().setParameter(...)

Show

Freddy Mallet added a comment - 20/May/09 3:20 AM You're right, the problem is located in the PmdMavenPluginHandler class : private void configureExclusions(MavenPlugin plugin) { if (exclusions!= null ) { for ( String pattern : exclusions.getWildcardPatterns()) { plugin.getConfiguration().setParameter( "excludes/exclude" , pattern); } } } I guess we should call plugin.getConfiguration().addParameter(...) instead of plugin.getConfiguration().setParameter(...)

Freddy Mallet made changes - 20/May/09 3:20 AM

Fix Version/s

1.10 [ 15233 ]

Hide

Permalink

Freddy Mallet added a comment - 20/May/09 3:21 AM

The CheckstyleMavenPluginHandler class must be updated as well.

Show

Freddy Mallet added a comment - 20/May/09 3:21 AM The CheckstyleMavenPluginHandler class must be updated as well.

Hide

Permalink

Anthonin Bonnefoy added a comment - 20/May/09 3:27 AM

Just replacing setParameter to addParameter seems to do the trick.
I made a unit test for this case.

Show

Anthonin Bonnefoy added a comment - 20/May/09 3:27 AM Just replacing setParameter to addParameter seems to do the trick. I made a unit test for this case.

Anthonin Bonnefoy made changes - 20/May/09 3:27 AM

Attachment

pmdExclusion.patch [ 42072 ]

Freddy Mallet made changes - 20/May/09 3:41 AM

Link

This issue is related to ~~SONAR-853~~ [ ~~SONAR-853~~ ]

Freddy Mallet made changes - 20/May/09 3:41 AM

Link

This issue is related to ~~SONAR-854~~ [ ~~SONAR-854~~ ]

Freddy Mallet made changes - 27/May/09 8:53 AM

Assignee

Freddy Mallet [ freddy.mallet ]