Sonar

Simplify sequence management

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.9
  • Component/s: Database
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Hi,

Following our discussion in http://jira.codehaus.org/browse/SONAR-178 , here is the patch I had in mind to simplify the sequence management.

It's based on the same principle I used to implement support of PostgreSQL sequences.

2 comments:

  • I don't have any Oracle database offhand so it really needs testing with Oracle;
  • I'm not sure it's worth it to have an AbstractRailsSequenceGenerator as there's not much to factorize. So, this patch doesn't implement it.

By the way, is it normal that the unit tests are currently failing?


Guillaume

Activity

Hide
Simon Brandhof added a comment -

Good news, it perfectly works on Oracle. Thank you. I agree that an AbstractRailsSequenceGenerator is useless.
Unit tests are fixed (week-end commits are never good...;o)

Show
Simon Brandhof added a comment - Good news, it perfectly works on Oracle. Thank you. I agree that an AbstractRailsSequenceGenerator is useless. Unit tests are fixed (week-end commits are never good...;o)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: