Surefire time is calculated wrong.

Jene, do you still have the issue ? Can you tell a bit more about it ? Are you talking about the time for the whole project or for a specific test ?

Thanks

Sample JUnitTest class from out QA Sandbox (used to eliminate duplicate entries between FindBugs, PMD and Checkstyle).

The sure-fire output for this file (see: <testsuite failures="0" time="0.27")

Resulting Sonar report: (see
<td>
<a href="#" onclick="javascript:showResourceViewer('30', null);">JUnitTest</a>
</td>
<td class="right">27 sec</td>
)

Should be 0.27 sec.

Jene, looks like an issue on the Local used to parse "0.27".

Could you give the default Local on your computer, I guess with this default Local 0.27 = 27 or something like that ?

thanks for your help
Freddy

System.out.println(">>>:" + locale.toString()); is >>>:nl_NL

Looks like the surfire report doesn't use the default Locale to generate the xml report. So we shouldn't use it to parse this report.

NumberFormat fr = NumberFormat.getInstance(new Locale("fr", "FR"));
NumberFormat us = NumberFormat.getInstance(new Locale("us", "US"));
NumberFormat nl = NumberFormat.getInstance(new Locale("nl", "NL"));
NumberFormat ch = NumberFormat.getInstance(new Locale("ch", "CH"));
		
assertEquals(0.345, us.parse("0.345").doubleValue(), 0.01);
assertEquals(0.345, ch.parse("0.345").doubleValue(), 0.01);
assertEquals(0, fr.parse("0.345").doubleValue(), 0.01);		
assertEquals(345, nl.parse("0.345").doubleValue(), 0.01);

After some checks, the surefire xml report code is using the following locale to format the time values in the report file :

private NumberFormat numberFormat = NumberFormat.getInstance( Locale.ENGLISH );

see :

http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-api/src/main/java/org/apache/maven/surefire/report/AbstractReporter.java?revision=601023&view=markup&pathrev=601023

We will also hardcode to Locale.ENGLISH the numberformat instance we use to parse this value and the issue will be fixed.