Sonar

org.sonar.squid.text.LinesFactory incorrectly handles Linux EOL

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Squid
  • Labels:
    None
  • Number of attachments :
    0

Description

As a consequence - metric 'lines' computed by org.sonar.squid.text.Source also can be incorrect. Here is a test to reproduce problem:

LinesFactory factory = new LinesFactory(new StringReader("1\r\n2\r\n"));
assertThat(factory.getLines().size()).isEqualTo(2);
factory = new LinesFactory(new StringReader("1\n2\n"));
assertThat(factory.getLines().size()).isEqualTo(2);

All versions at least from Sonar 2.5 to 3.2 affected.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SONARPLUGINS-2118 Incorrect computation of number of lines in case of Linux EOL

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Freddy Mallet added a comment -

@Evgeny, perhaps we should close this issue "Won't Fix" as the goal is to depreciate and then remove this class ?

Show
Freddy Mallet added a comment - @Evgeny, perhaps we should close this issue "Won't Fix" as the goal is to depreciate and then remove this class ?
Hide
Permalink
Evgeny Mandrikov added a comment -

@Freddy, IMO we should close this ticket only when we will deprecate this class.

Show
Evgeny Mandrikov added a comment - @Freddy, IMO we should close this ticket only when we will deprecate this class.
Hide
Permalink
Freddy Mallet added a comment -

Can I close this ticket @Evgeny ?

Show
Freddy Mallet added a comment - Can I close this ticket @Evgeny ?
Hide
Permalink
Freddy Mallet added a comment -

Is this class deprecated @Evgeny ?

Show
Freddy Mallet added a comment - Is this class deprecated @Evgeny ?
Hide
Permalink
Evgeny Mandrikov added a comment -

@Freddy not yet, moreover it's used by some plugins (like Groovy - see SONARPLUGINS-2118)

Show
Evgeny Mandrikov added a comment - @Freddy not yet, moreover it's used by some plugins (like Groovy - see SONARPLUGINS-2118 )

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: