SonarQube

The "Filters" page should be renamed "My Filters" and should be moved close to the "My Profile" page

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Moreover :

  • This My Filters page should only display the filters created by the current user -> Which means that the "Shared Filters" section in the "Managed Filters" page should be removed.
  • The global dashboards should now be the first pages to be displayed in the left navigation bar

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SONAR-3480 There is no way to delete one of the three default Filters : Projects, Treemap and My Favourites

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SONAR-3481 The three default Filters appear in the "My Filters" page of all users whereas they should only appear for the sonar administrators

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SONAR-3483 The "My Filters" page should not display filters which are owned by another user

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Gageot added a comment -

Done

Show
David Gageot added a comment - Done
Hide
Permalink
David Gageot added a comment -

Closed by error

Show
David Gageot added a comment - Closed by error
Hide
Permalink
David Gageot added a comment -

Done

Show
David Gageot added a comment - Done
Hide
Permalink
David Gageot added a comment -

Now that the migration is done, everything should be ok

Show
David Gageot added a comment - Now that the migration is done, everything should be ok
Hide
Permalink
Freddy Mallet added a comment -

Hi David, I'm reopening this ticket because the "My Filters" page is not available when the user is not an administrator of the Sonar platform. Every Sonar user should be able to access to his "My Filters" page.

Show
Freddy Mallet added a comment - Hi David, I'm reopening this ticket because the "My Filters" page is not available when the user is not an administrator of the Sonar platform. Every Sonar user should be able to access to his "My Filters" page.
Hide
Permalink
David Gageot added a comment -

Fixed visibility for any authenticated user

Show
David Gageot added a comment - Fixed visibility for any authenticated user
Hide
Permalink
Freddy Mallet added a comment -

Manually tested !

Show
Freddy Mallet added a comment - Manually tested !
Hide
Permalink
Freddy Mallet added a comment -

Don't know why David but the "My Filters" page seems to be broken wither Derby. We get the following error when trying to access to this page :

2.05.15 08:30:40 ERROR o.s.s.ui.JRubyFacade  Fail to render: http://localhost:9000/filters/manage
ActiveRecord::JDBCError: Syntax error: Encountered "true" at line 1, column 55.: SELECT * FROM "FILTERS" WHERE (user_id=1 or shared is true) 
	/Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:219:in `log'
	/Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:210:in `log'
	/Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/gems/activerecord-jdbc-adapter-1.1.3/lib/arjdbc/jdbc/adapter.rb:183:in `execute'
	/Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/gems/activerecord-jdbc-adapter-1.1.3/lib/arjdbc/derby/adapter.rb:213:in `execute'
	arjdbc/derby/DerbyModule.java:289:in `select_all'
	/Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/base.rb:661:in `find_by_sql'
	/Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/base.rb:1548:in `find_every'
Show
Freddy Mallet added a comment - Don't know why David but the "My Filters" page seems to be broken wither Derby. We get the following error when trying to access to this page : 2.05.15 08:30:40 ERROR o.s.s.ui.JRubyFacade Fail to render: http: //localhost:9000/filters/manage ActiveRecord::JDBCError: Syntax error: Encountered " true " at line 1, column 55.: SELECT * FROM "FILTERS" WHERE (user_id=1 or shared is true ) /Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:219:in `log' /Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:210:in `log' /Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/gems/activerecord-jdbc-adapter-1.1.3/lib/arjdbc/jdbc/adapter.rb:183:in `execute' /Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/gems/activerecord-jdbc-adapter-1.1.3/lib/arjdbc/derby/adapter.rb:213:in `execute' arjdbc/derby/DerbyModule.java:289:in `select_all' /Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/base.rb:661:in `find_by_sql' /Users/fmallet/Dropbox/softwares/sonar-3.1-SNAPSHOT/war/sonar-server/WEB-INF/vendor/rails/activerecord/lib/active_record/base.rb:1548:in `find_every'
Hide
Permalink
Freddy Mallet added a comment -

And indeed I do confirm that we don't face this issue for instance with MySQL

Show
Freddy Mallet added a comment - And indeed I do confirm that we don't face this issue for instance with MySQL
Hide
Permalink
David Gageot added a comment -

Fixed. Two SQL queries used a postgresql specific syntax.

Show
David Gageot added a comment - Fixed. Two SQL queries used a postgresql specific syntax.
Hide
Permalink
Freddy Mallet added a comment - - edited

Manually tested !

I've created the three following bugs that we'll fix in the next 3.2 version : SONAR-3481, SONAR-3480 and SONAR-3483

Show
Freddy Mallet added a comment - - edited Manually tested ! I've created the three following bugs that we'll fix in the next 3.2 version : SONAR-3481 , SONAR-3480 and SONAR-3483
Hide
Permalink
David Gageot added a comment -

IT test done

Show
David Gageot added a comment - IT test done

People

  • Assignee:
    Simon Brandhof
    Reporter:
    Freddy Mallet
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: