SonarQube

Half coverage for simple, one statement methods which are actually covered by junit

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 2.13.1
  • Fix Version/s: None
  • Component/s: Code Coverage
  • Labels:
  • Environment:
    Sonar v.2.13.1 configured with JaCoCo
  • Number of attachments :
    5

Description

Sonar shows half code coverage for single statement methods. As these lines are without if or ternary operator I don't think it could be half covered anyway.
The Eclipse EclEmma plugin (EclEmma Java Code Coverage version 2.1.0.201202261248) shows full coverage.

Sonar v.2.13.1 configured with JaCoCo

DefaultEventLogService.java
@Service("defaultEventLogService ")
public class DefaultEventLogService implements EventLogService {

 @Autowired
 private EventLogRepository eventLogRepository;

 @Transactional
 public void createEventLog(EventLog eventLog) {
   eventLogRepository.createEventLog(eventLog);
 }
}
DefaultEventLogServiceTest.java
@RunWith(MockitoJUnitRunner.class)
public class DefaultEventLogServiceTest {

 @InjectMocks
 private final EventLogService victim = new DefaultEventLogService();

 @Mock
 private EventLogRepository eventLogRepository;

 @Mock
 private EventLog eventLog;

 @Test
 public void createEventLog() {
  victim.createEventLog(eventLog);
  verify(eventLogRepository).createEventLog(eventLog);
 }
}

Even if the test is without MockitoJUnitRunner, with setUp() and ReflectionTestUtils, Sonar shows half coverage.

  1. Text File
    DefaultEventLogService.class.txt
    30/Mar/12 9:07 AM
    6 kB
    Ferenc Gratzer
  1. eclemma-coverage.jpg
    77 kB
    30/Mar/12 4:47 AM
  2. Sonar-half-coverage.jpg
    68 kB
    30/Mar/12 4:14 AM
  3. Sonar-half-coverage2.jpg
    20 kB
    30/Mar/12 9:05 AM
  4. Sonar-half-coverage3.jpg
    27 kB
    30/Mar/12 9:05 AM

Activity

Ascending order - Click to sort in descending order
Ferenc Gratzer made changes -
Field Original Value New Value
Attachment Sonar-half-coverage.jpg [ 59422 ]
Hide
Permalink
Ferenc Gratzer added a comment -

Sonar half coverage for single statement

Show
Ferenc Gratzer added a comment - Sonar half coverage for single statement
Ferenc Gratzer made changes -
Attachment Sonar-half-coverage.jpg [ 59423 ]
Hide
Permalink
Freddy Mallet added a comment -

Hi Ferenc, could you attach to this ticket the bytecode associated to this 'DefaultEventLogService' java file ? Thanks

Show
Freddy Mallet added a comment - Hi Ferenc, could you attach to this ticket the bytecode associated to this 'DefaultEventLogService' java file ? Thanks
Freddy Mallet made changes -
Labels jacoco
Freddy Mallet made changes -
Assignee Freddy Mallet [ freddy.mallet ]
Hide
Permalink
Ferenc Gratzer added a comment -

EclEmma coverage

Show
Ferenc Gratzer added a comment - EclEmma coverage
Ferenc Gratzer made changes -
Attachment eclemma-coverage.jpg [ 59424 ]
Hide
Permalink
Ferenc Gratzer added a comment -

It seems to me that the analysis of the first line is incorrect. The issue happens with bigger methods, too.

Show
Ferenc Gratzer added a comment - It seems to me that the analysis of the first line is incorrect. The issue happens with bigger methods, too.
Ferenc Gratzer made changes -
Attachment Sonar-half-coverage2.jpg [ 59426 ]
Attachment Sonar-half-coverage3.jpg [ 59427 ]
Hide
Permalink
Ferenc Gratzer added a comment - - edited

Bytecode. The package names in proprietary classes have been altered.

Show
Ferenc Gratzer added a comment - - edited Bytecode. The package names in proprietary classes have been altered.
Ferenc Gratzer made changes -
Attachment DefaultEventLogService.class.txt [ 59428 ]
Hide
Permalink
Freddy Mallet added a comment -

And last request Ferenc: could you try to launch the analysis several times just to be sure that you always get the same behavior from Jacoco ?
Thanks

Show
Freddy Mallet added a comment - And last request Ferenc: could you try to launch the analysis several times just to be sure that you always get the same behavior from Jacoco ? Thanks
Hide
Permalink
Ferenc Gratzer added a comment -

Sonar build is scheduled for every weekday, and it always shows the same result I attached to this issue.

Show
Ferenc Gratzer added a comment - Sonar build is scheduled for every weekday, and it always shows the same result I attached to this issue.
Hide
Permalink
Freddy Mallet added a comment -

Ferenc, I've decompiled the bytecode and indeed there isn't any additional branches but I'm pretty sure that the annotation (like the @Transactional one) are used to modify this bytecode. If you're using Maven to build your application, could you send me the bytecode generated after the full build cycle ?
Thanks

Show
Freddy Mallet added a comment - Ferenc, I've decompiled the bytecode and indeed there isn't any additional branches but I'm pretty sure that the annotation (like the @Transactional one) are used to modify this bytecode. If you're using Maven to build your application, could you send me the bytecode generated after the full build cycle ? Thanks
Hide
Permalink
Ferenc Gratzer added a comment - - edited

The attached bytecode was taken at the end of the Maven build.
I think in this case the @Transactional annotation is managed by a JDK dynamic proxy created at load-time.

 <tx:annotation-driven transaction-manager="transactionManager" order="10" />
Show
Ferenc Gratzer added a comment - - edited The attached bytecode was taken at the end of the Maven build. I think in this case the @Transactional annotation is managed by a JDK dynamic proxy created at load-time. <tx:annotation-driven transaction-manager= "transactionManager" order= "10" />
Hide
Permalink
Freddy Mallet added a comment -

Hi Ferenc, I'm sorry but I'm stopping my investigations on this subject. What's really strange is that EclEmma plugin is also based on Jacoco so I don't manage to understand why we don't get the same results in Sonar and in EclEmma.

Show
Freddy Mallet added a comment - Hi Ferenc, I'm sorry but I'm stopping my investigations on this subject. What's really strange is that EclEmma plugin is also based on Jacoco so I don't manage to understand why we don't get the same results in Sonar and in EclEmma.
Freddy Mallet made changes -
Assignee Freddy Mallet [ freddy.mallet ]
Freddy Mallet made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Cannot Reproduce [ 5 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Ferenc Gratzer
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: