SonarQube
  1. SonarQube
  2. SONAR-3238

Deprecate old format for DUPLICATIONS_DATA

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.14
    • Component/s: Duplications
    • Labels:
      None
    • Number of attachments :
      0

      Description

      This format has following drawbacks:

      • assumes that amount of lines is the same for both resources, which is obviously wrong in general case
      • duplication can span no more than two resources
      • and they both in same project

      But we can't just drop it, because we should be able to display duplications before next analysis of project.
      So would be better to stop using it during saving, and later remove completely.

        Issue Links

          Activity

          Evgeny Mandrikov made changes -
          Field Original Value New Value
          Description This format has following drawbacks:
          * assumes that amount of lines is the same for both resources, which is obviously wrong in general case
          * duplication can span no more than two resources
          * and they both in same project

          But we can't just drop it, because we should be able to display duplications before next analysis of project.
          So would be better to stop using it during saving, and later remove completely.
          Evgeny Mandrikov made changes -
          Link This issue is related to SONAR-3240 [ SONAR-3240 ]
          Evgeny Mandrikov made changes -
          Link This issue is related to SONARPLUGINS-978 [ SONARPLUGINS-978 ]
          Evgeny Mandrikov made changes -
          Link This issue relates to SONAR-3182 [ SONAR-3182 ]
          Hide
          Evgeny Mandrikov added a comment - - edited

          Done in 7dc3bc3.
          However should be noted that only format was changed and all limitations of PMD still here :

          • assumes that amount of lines is the same for both resources
          • in some cases duplicated blocks might be shown incorrectly (SONAR-3131)
          Show
          Evgeny Mandrikov added a comment - - edited Done in 7dc3bc3 . However should be noted that only format was changed and all limitations of PMD still here : assumes that amount of lines is the same for both resources in some cases duplicated blocks might be shown incorrectly ( SONAR-3131 )
          Evgeny Mandrikov made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Evgeny Mandrikov [ godin ] Freddy Mallet [ freddy.mallet ]
          Resolution Fixed [ 1 ]
          Freddy Mallet made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Freddy Mallet [ freddy.mallet ] Evgeny Mandrikov [ godin ]

            People

            • Assignee:
              Evgeny Mandrikov
              Reporter:
              Evgeny Mandrikov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: