Sonar

Unable to see or update a review which has been created/assigned/commented by a deleted user

Details

  • Number of attachments :
    0

Description

When having an open Review assigned and I click on the "Reviews" Menu Entry I get an "We're sorry, but something went wrong.".
The sonar Logfile shows 

2011.12.16 14:08:54 ERROR o.s.s.ui.JRubyFacade  Fail to render: http://foo.com/reviews?statuses%5B%5D=&severities%5B%5D=&projects%5B%5D=4711&author_login=&assignee_login=bar&false_positives=without&review_id=&sort=&asc=false&commit=Search
undefined method `user' for nil:NilClass
        On line #152 of app/views/reviews/index.html.erb

    149: <%= link_to h(review.title), :controller => "reviews", :action => "view", :id => review.id -%>
    150: <div class="comment-excerpt">
    151: <img src="<%= ApplicationController.root_context -%>/images/reviews/comment.png"/>
    152: &nbsp;<b><%= comment.user.name -%> :</b>
    153: <%= comment.excerpt -%>
    154: </div>
    155: </td>

    app/views/reviews/index.html.erb:152
    org/jruby/RubyArray.java:1602:in `each'
    app/views/reviews/index.html.erb:139
    org/jruby/RubyKernel.java:2056:in `send'
    org/jruby/RubyKernel.java:2064:in `send'
    org/jruby/RubyProc.java:268:in `call'
    org/jruby/RubyProc.java:228:in `call'
    file:lib/jruby-rack-1.0.0.1.jar!/vendor/rack-1.2.1/rack/head.rb:9:in `call'
    file:lib/jruby-rack-1.0.0.1.jar!/vendor/rack-1.2.1/rack/methodoverride.rb:24:in `call'
    file:lib/jruby-rack-1.0.0.1.jar!/rack/adapter/rails.rb:36:in `serve_rails'
    file:lib/jruby-rack-1.0.0.1.jar!/rack/adapter/rails.rb:41:in `call'
    file:lib/jruby-rack-1.0.0.1.jar!/jruby/rack/rails.rb:185:in `call'
    file:lib/jruby-rack-1.0.0.1.jar!/rack/handler/servlet.rb:19:in `call'

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. SONAR-3258 No more delete users in the Sonar DB but deactivate them

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. SONAR-3223 Error in review search when result ties to a deleted resource

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. SONAR-2620 A user should never be deleted but disable

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dürrmeier added a comment -

Happens also for users which have not been deleted

Show
Martin Dürrmeier added a comment - Happens also for users which have not been deleted
Hide
Permalink
Martin Dürrmeier added a comment -

I suggest to remove the 'deleted' from the Issue Title as it also happens when a user was not deleted

Show
Martin Dürrmeier added a comment - I suggest to remove the 'deleted' from the Issue Title as it also happens when a user was not deleted
Hide
Permalink
Freddy Mallet added a comment -

So Martin, if this error also happens when the user exists that means that you don't manage to see any review in your context ?

Show
Freddy Mallet added a comment - So Martin, if this error also happens when the user exists that means that you don't manage to see any review in your context ?
Hide
Permalink
Martin Dürrmeier added a comment -

Exactly Freddy. We already deleted the project in sonar and added it again but it still happens. Can you reproduce this?

Show
Martin Dürrmeier added a comment - Exactly Freddy. We already deleted the project in sonar and added it again but it still happens. Can you reproduce this?
Hide
Permalink
Freddy Mallet added a comment -

We can reproduce exactly this issue but only when the user associated to the review has been deleted.

Show
Freddy Mallet added a comment - We can reproduce exactly this issue but only when the user associated to the review has been deleted.
Hide
Permalink
Fabrice Bellingard added a comment -

A migration script removes comments associated to a deleted user and removes author/assignee on a review if this is a deleted user.

Show
Fabrice Bellingard added a comment - A migration script removes comments associated to a deleted user and removes author/assignee on a review if this is a deleted user.
Hide
Permalink
Freddy Mallet added a comment -

Manually tested

Show
Freddy Mallet added a comment - Manually tested
Hide
Permalink
Fabrice Bellingard added a comment -

No need for IT as "really" deleting a user is not possible anymore with Sonar (SONAR-3258).

Show
Fabrice Bellingard added a comment - No need for IT as "really" deleting a user is not possible anymore with Sonar ( SONAR-3258 ).

People

  • Assignee:
    Fabrice Bellingard
    Reporter:
    Martin Dürrmeier
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: