Refactor event handling in Sonar Web

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.11
  • Fix Version/s: 2.12
  • Component/s: Dashboard, Events, History
  • Labels:
    None

Description

Event administration (creation / modification / deletion) should not be done in the event widget that is displayed on dashboard.
Instead, this should be handled in the same service as the snapshot deletion ("Delete history"), and an event must be necessarily linked to a snapshot to prevent side effects (like bug SONAR-2811).

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. SONAR-2811 Time Machine won't compare to previous versions if said version has been manually modified.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. SONAR-3075 "value too long" inserting into events after updating a quality profile

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. SONAR-801 Events on Dashboard confused for same project dates

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Freddy Mallet added a comment -

It's currently possible to create an event without defining the category which leads to an unexpected behavior : those events are not displayed in the "Events" widget. I think that we should forbid to create an event without providing an event category.

Show
Freddy Mallet added a comment - It's currently possible to create an event without defining the category which leads to an unexpected behavior : those events are not displayed in the "Events" widget. I think that we should forbid to create an event without providing an event category.
Hide
Permalink
Freddy Mallet added a comment -

In the updated "Events" widget the right border is not displayed with Chrome.

Show
Freddy Mallet added a comment - In the updated "Events" widget the right border is not displayed with Chrome.
Hide
Permalink
Freddy Mallet added a comment -

It should not be possible to "remove" the version on the last snapshot to prevent any side effect in the current "TimeMachine" service

Show
Freddy Mallet added a comment - It should not be possible to "remove" the version on the last snapshot to prevent any side effect in the current "TimeMachine" service
Hide
Permalink
Freddy Mallet added a comment -

As this is no more possible to make any modification from the "Events" widget, it would be better to display this "Events" widget even on sub-projects.

Show
Freddy Mallet added a comment - As this is no more possible to make any modification from the "Events" widget, it would be better to display this "Events" widget even on sub-projects.
Hide
Permalink
Fabrice Bellingard added a comment -

Updates pushed to master:

  • Make it impossible to create event without a category (new "Other" category)
  • Fix display issue on Chrome
  • Make it impossible to remove version from last snapshot
  • Show event widget on sub-projects
  • Update purge mechanism to delete events that are not attached to a snapshot or attached to an unexisting snapshot
Show
Fabrice Bellingard added a comment - Updates pushed to master:
  • Make it impossible to create event without a category (new "Other" category)
  • Fix display issue on Chrome
  • Make it impossible to remove version from last snapshot
  • Show event widget on sub-projects
  • Update purge mechanism to delete events that are not attached to a snapshot or attached to an unexisting snapshot
Hide
Permalink
Freddy Mallet added a comment -

Could you just prevent users from creating twice the same events ? This can lead either to error when one of this duplicated event is on the last snapshot or to unexpected behavior when using this version in differential views.

Show
Freddy Mallet added a comment - Could you just prevent users from creating twice the same events ? This can lead either to error when one of this duplicated event is on the last snapshot or to unexpected behavior when using this version in differential views.
Hide
Permalink
Fabrice Bellingard added a comment -

Prevent user from creating twice the same event.

  • Most importantly for versions
  • Check also made on any event
  • WS API updated accordingly
Show
Fabrice Bellingard added a comment - Prevent user from creating twice the same event.
  • Most importantly for versions
  • Check also made on any event
  • WS API updated accordingly
Hide
Permalink
Freddy Mallet added a comment -

Manually tested

Show
Freddy Mallet added a comment - Manually tested
Hide
Permalink
Fabrice Bellingard added a comment -

ITs done.

Show
Fabrice Bellingard added a comment - ITs done.

People

  • Assignee:
    Fabrice Bellingard
    Reporter:
    Fabrice Bellingard
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: