Sonar

LCOM4 flags benign groups - Members with Initial Capitals

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.12
  • Component/s: Metrics, Squid
  • Labels:
  • Number of attachments :
    0

Description

I have a class that's a pure data structure that's getting an LCOM4 score of 5 because of the way members and methods are named.
Specifically it has a couple of members which are named (incorrectly) with initial capitals, e.g.
private String MyString;

The LCOM4 scan flags each of those members and their (properly named) getters and setters, e.g.
public String getMyString()
public void setMyString(String aString)

Please enhance the getter/setter recognition to handle variables named with an initial capital letter

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. SONAR-2724 LCOM4 flags benign groups - list management

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Dinesh Bolkensteyn added a comment -

Indeed, the setter/getter recognition algorithm is not optimal.

The method in the code following should be recognized as an accessor.

public class JavaBeanWithUppercaseFields {
  
  private String FirstName;
  
  public String getFirstName() {
    return FirstName;
  }
  
}
Show
Dinesh Bolkensteyn added a comment - Indeed, the setter/getter recognition algorithm is not optimal. The method in the code following should be recognized as an accessor. public class JavaBeanWithUppercaseFields { private String FirstName; public String getFirstName() { return FirstName; } }

People

  • Assignee:
    Dinesh Bolkensteyn
    Reporter:
    G. Ann Campbell
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: