jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Sonar
  • SONAR-2046

Synchronize unmarshallers from sonar-ws-client to sonar-gwt-api

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.6
  • Component/s: API, Web Services
  • Labels:
    None

Description

It's a shame to have duplicated code between sonar-ws-client and sonar-gwt-api : problem is that we can't use same classes to parse JSON, but actually code is the same. In order to remove this duplication we can reuse the same principle as for WSUtils. Disadvantage - type safety, but I think that this is not a big problem, since we have unit tests for unmarshallers. In fact it would be better to use emulation of types from org.json.simple for GWT, but this solution is more straightforward.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    SONAR-2046.patch
    12/Dec/10 1:17 AM
    53 kB
    Evgeny Mandrikov

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Evgeny Mandrikov added a comment - 27/Jan/11 9:25 AM

Done in https://github.com/SonarSource/sonar/commit/815899837ca07904fe9dc9223b4a4e8ac486cb59

Show
Evgeny Mandrikov added a comment - 27/Jan/11 9:25 AM Done in https://github.com/SonarSource/sonar/commit/815899837ca07904fe9dc9223b4a4e8ac486cb59

People

  • Assignee:
    Evgeny Mandrikov
    Reporter:
    Evgeny Mandrikov
Vote (0)
Watch (0)

Dates

  • Created:
    12/Dec/10 12:40 AM
    Updated:
    13/Feb/11 3:57 AM
    Resolved:
    27/Jan/11 9:25 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.